[Backport 2.x] Fix circular dependency in Settings initialization by opensearch-trigger-bot[bot] · Pull Request #10317 · opensearch-project/OpenSearch

opensearch-trigger-bot · 2023-10-02T22:20:01Z

Backport d3bf230 from #10194.

There was a weird circular class-loading dependency between Settings and Settings.Builder that could result in ClassLoader deadlock if multiple threads trigger class-loading of Settings at the same time. Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit d3bf230) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions · 2023-10-02T22:44:25Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26646/
CommitID: 3de6042
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-02T22:53:45Z

Compatibility status:

Checks if related components are compatible with change 1f624fe

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-10-03T00:44:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26657/
CommitID: 3de6042
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

codecov · 2023-10-03T15:40:38Z

Codecov Report

Merging #10317 (1f624fe) into 2.x (2f430ed) will increase coverage by 0.03%.
Report is 6 commits behind head on 2.x.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x   #10317      +/-   ##
============================================
+ Coverage     70.87%   70.91%   +0.03%     
- Complexity    58354    58406      +52     
============================================
  Files          4816     4816              
  Lines        275763   275763              
  Branches      40534    40534              
============================================
+ Hits         195440   195544     +104     
+ Misses        63664    63536     -128     
- Partials      16659    16683      +24

Files	Coverage Δ
.../java/org/opensearch/common/settings/Settings.java	`80.62% <100.00%> (-0.20%)`	⬇️

... and 458 files with indirect coverage changes

github-actions · 2023-10-03T16:02:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26732/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-03T16:04:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/26731/
CommitID: 3de6042

github-actions · 2023-10-03T17:04:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26749/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-03T18:26:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26760/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-03T19:10:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26774/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-03T21:36:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26789/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-03T23:00:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26796/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-03T23:53:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26804/
CommitID: 1f624fe
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-04T01:10:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch
      1 org.opensearch.index.shard.RemoteIndexShardTests.testRepicaCleansUpOldCommitsWhenReceivingNew

URL: https://build.ci.opensearch.org/job/gradle-check/26812/
CommitID: 1f624fe
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

reta approved these changes Oct 2, 2023

View reviewed changes

Merge branch '2.x' into backport/backport-10194-to-2.x

1f624fe

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

reta merged commit 6170dd9 into 2.x Oct 4, 2023

reta added the v2.11.0 Issues and PRs related to version 2.11.0 label Oct 4, 2023

github-actions bot deleted the backport/backport-10194-to-2.x branch October 4, 2023 01:35

Conversation

opensearch-trigger-bot bot commented Oct 2, 2023

Uh oh!

github-actions bot commented Oct 2, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 3, 2023 •

edited

Loading