Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce code coverage collection to Cypress runs #9084

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AMoo-Miki
Copy link
Collaborator

Description

  • Introduce code coverage collection to Cypress runs
  • Add coverage reporting to Cypress CI
  • Enable Cypress tests to detect features of the OSD instance they are running against
  • Turn on test isolation when security is disabled

Changelog

  • test: Introduce code coverage collection to Cypress runs
  • test: Enable Cypress tests to detect features of the OSD instance they are running against
  • test: Turn on test isolation when security is disabled
  • infra: Add coverage reporting to Cypress CI

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Also:
* Add coverage reporting to Cypress CI
…running against

Also:
* Turn on test isolation when security is disabled

Signed-off-by: Miki <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.99%. Comparing base (06bcf20) to head (4220384).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/osd-babel-preset/common_preset.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9084      +/-   ##
==========================================
- Coverage   60.86%   56.99%   -3.87%     
==========================================
  Files        3808     4132     +324     
  Lines       91159   110935   +19776     
  Branches    14393    23302    +8909     
==========================================
+ Hits        55482    63230    +7748     
- Misses      32182    44620   +12438     
+ Partials     3495     3085     -410     
Flag Coverage Δ
Linux_1 28.99% <50.00%> (-0.01%) ⬇️
Linux_2 ?
Linux_3 38.01% <50.00%> (+0.07%) ⬆️
Linux_4 29.01% <0.00%> (-0.01%) ⬇️
Windows_1 29.00% <50.00%> (-0.01%) ⬇️
Windows_2 56.33% <50.00%> (-0.01%) ⬇️
Windows_3 38.01% <50.00%> (+0.08%) ⬆️
Windows_4 29.01% <0.00%> (-0.01%) ⬇️
cypress12 28.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants