Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] refactor: Remove permission validation in workspace form #9076

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c61c7cd from #9065.

…9065)

* refactor: remove permission verification in workspace form

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #9065 created/updated

* remove extra import in test

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit c61c7cd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.86%. Comparing base (be4e262) to head (1f49b32).
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #9076      +/-   ##
==========================================
- Coverage   60.88%   60.86%   -0.03%     
==========================================
  Files        3807     3807              
  Lines       91162    91112      -50     
  Branches    14392    14375      -17     
==========================================
- Hits        55504    55454      -50     
+ Misses      32131    32130       -1     
- Partials     3527     3528       +1     
Flag Coverage Δ
Linux_1 28.99% <100.00%> (-0.06%) ⬇️
Linux_2 56.52% <ø> (ø)
Linux_3 37.84% <ø> (ø)
Linux_4 30.02% <ø> (ø)
Windows_1 29.00% <100.00%> (-0.06%) ⬇️
Windows_2 56.48% <ø> (ø)
Windows_3 37.84% <ø> (ø)
Windows_4 30.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 1050dee into 2.x Dec 24, 2024
69 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-9065-to-2.x branch December 24, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset v2.19.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants