Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data source details to use small buttons #9057

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ritvibhatt
Copy link

@ritvibhatt ritvibhatt commented Dec 13, 2024

Description

  • Use small buttons in tabs in data source details
  • Change "Refresh" button in accelerations tab to "Update"

Issues Resolved

Screenshot

Associated Objects table:
Before:
Screenshot 2024-12-13 at 9 22 30 AM
After:
Screenshot 2024-12-12 at 4 10 15 PM

Accelerations table:
Before:
Screenshot 2024-12-13 at 9 22 40 AM
After:
Screenshot 2024-12-12 at 4 10 27 PM

Testing the changes

Changelog

  • refactor: Update data source details tabs to use small buttons

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (f85cd6d) to head (04c15d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9057      +/-   ##
==========================================
+ Coverage   60.86%   60.87%   +0.01%     
==========================================
  Files        3808     3808              
  Lines       91175    91175              
  Branches    14396    14396              
==========================================
+ Hits        55495    55505      +10     
+ Misses      32140    32129      -11     
- Partials     3540     3541       +1     
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.38% <ø> (ø)
Linux_3 37.94% <ø> (-0.01%) ⬇️
Linux_4 29.01% <ø> (ø)
Windows_1 29.02% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.95% <ø> (ø)
Windows_4 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ritvi Bhatt added 2 commits December 13, 2024 14:18
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants