Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Dec 13, 2024

Description

Use HTTP service instead of fetch for plugin check

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.09%. Comparing base (f06a478) to head (1208f40).

Files with missing lines Patch % Lines
...ation_creation/selectors/preview_sql_defintion.tsx 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f06a478) and HEAD (1208f40). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f06a478) HEAD (1208f40)
Windows_3 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9052      +/-   ##
==========================================
- Coverage   60.86%   51.09%   -9.78%     
==========================================
  Files        3808     3452     -356     
  Lines       91209    81963    -9246     
  Branches    14410    12532    -1878     
==========================================
- Hits        55514    41878   -13636     
- Misses      32154    37792    +5638     
+ Partials     3541     2293    -1248     
Flag Coverage Δ
Linux_1 29.02% <0.00%> (ø)
Linux_2 56.38% <ø> (ø)
Linux_4 29.01% <0.00%> (ø)
Windows_1 29.03% <0.00%> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 ?
Windows_4 29.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@RyanL1997 RyanL1997 changed the title [WIP] Use HTTP service instead of fetch for plugin check Use HTTP service instead of fetch for plugin check Dec 17, 2024
@RyanL1997 RyanL1997 marked this pull request as ready for review December 17, 2024 18:06
@RyanL1997 RyanL1997 changed the title Use HTTP service instead of fetch for plugin check [Enhancement] Use HTTP service instead of fetch for plugin check Dec 17, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

1 similar comment
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SQL Query Workbench Plugin Status Check Failure in Direct Query Datasource
1 participant