Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a script to run bwc test #879

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 18, 2021

Description

This script is used to run bwc tests on a remote cluster.
It will first pull opensearch-dashboards-functional-test
repo in a tmp folder. Then move the required cypress tests
in and run the bwc tests.

partically solved:

opensearch-project/opensearch-build#705

Signed-off-by: Anan Zhuang [email protected]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

This script is used to run bwc tests on a remote cluster.
It will first pull opensearch-dashboards-functional-test
repo in a tmp folder. Then move the required cypress tests
in and run the bwc tests.

partically solved:
opensearch-project/opensearch-build#705

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh self-assigned this Oct 18, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 3b0f861

bwc.sh Outdated
@@ -0,0 +1,99 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this file be renamed to bwctest.sh so it can this logic can stay the same: https://github.com/opensearch-project/opensearch-build/blob/main/src/paths/script_finder.py#L100

Unless you think it should be bwc.sh, then we can figure it out from there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, I will update the file name. Thanks for pointing it out.

bwc.sh Outdated
fi

mkdir "$dir"
git clone https://github.com/opensearch-project/opensearch-dashboards-functional-test "$dir"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@kavilla
Copy link
Member

kavilla commented Oct 18, 2021

Looks great! Just one comment on the name of the file and should we add something to documentation?

@dblock
Copy link
Member

dblock commented Oct 19, 2021

You might want this in scripts/ to keep things organized. I think the calling code supports both.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 744cb50

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with dB. it could go in scripts. but lgtm! thanks

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small nit is that there is no newline at the end of the file but otherwise everything is great.

@ananzh ananzh merged commit 7be3529 into opensearch-project:main Oct 25, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Oct 25, 2021
This script is used to run bwc tests on a remote cluster.
It will first pull opensearch-dashboards-functional-test
repo in a tmp folder. Then move the required cypress tests
in and run the bwc tests.

partically solved:
opensearch-project/opensearch-build#705

backport PR:
opensearch-project#879

Signed-off-by: Anan Zhuang <[email protected]>

* change file name to match opensearch-build script_finder.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh mentioned this pull request Oct 25, 2021
5 tasks
ananzh added a commit that referenced this pull request Oct 26, 2021
This script is used to run bwc tests on a remote cluster.
It will first pull opensearch-dashboards-functional-test
repo in a tmp folder. Then move the required cypress tests
in and run the bwc tests.

partically solved:
opensearch-project/opensearch-build#705

backport PR:
#879

Signed-off-by: Anan Zhuang <[email protected]>

* change file name to match opensearch-build script_finder.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh added the v1.3.0 label Nov 1, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Dec 16, 2021
* add a script to run bwc test

This script is used to run bwc tests on a remote cluster.
It will first pull opensearch-dashboards-functional-test
repo in a tmp folder. Then move the required cypress tests
in and run the bwc tests.

partically solved:
opensearch-project/opensearch-build#705

Signed-off-by: Anan Zhuang <[email protected]>

* change file name to match opensearch-build script_finder.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh deleted the bwc-script branch February 23, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants