-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a script to run bwc test #879
Conversation
This script is used to run bwc tests on a remote cluster. It will first pull opensearch-dashboards-functional-test repo in a tmp folder. Then move the required cypress tests in and run the bwc tests. partically solved: opensearch-project/opensearch-build#705 Signed-off-by: Anan Zhuang <[email protected]>
✅ DCO Check Passed 3b0f861 |
bwc.sh
Outdated
@@ -0,0 +1,99 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be renamed to bwctest.sh
so it can this logic can stay the same: https://github.com/opensearch-project/opensearch-build/blob/main/src/paths/script_finder.py#L100
Unless you think it should be bwc.sh
, then we can figure it out from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah, I will update the file name. Thanks for pointing it out.
bwc.sh
Outdated
fi | ||
|
||
mkdir "$dir" | ||
git clone https://github.com/opensearch-project/opensearch-dashboards-functional-test "$dir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Looks great! Just one comment on the name of the file and should we add something to documentation? |
You might want this in |
Signed-off-by: Anan Zhuang <[email protected]>
✅ DCO Check Passed 744cb50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with dB. it could go in scripts. but lgtm! thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One small nit is that there is no newline at the end of the file but otherwise everything is great.
This script is used to run bwc tests on a remote cluster. It will first pull opensearch-dashboards-functional-test repo in a tmp folder. Then move the required cypress tests in and run the bwc tests. partically solved: opensearch-project/opensearch-build#705 backport PR: opensearch-project#879 Signed-off-by: Anan Zhuang <[email protected]> * change file name to match opensearch-build script_finder. Signed-off-by: Anan Zhuang <[email protected]>
This script is used to run bwc tests on a remote cluster. It will first pull opensearch-dashboards-functional-test repo in a tmp folder. Then move the required cypress tests in and run the bwc tests. partically solved: opensearch-project/opensearch-build#705 backport PR: #879 Signed-off-by: Anan Zhuang <[email protected]> * change file name to match opensearch-build script_finder. Signed-off-by: Anan Zhuang <[email protected]>
* add a script to run bwc test This script is used to run bwc tests on a remote cluster. It will first pull opensearch-dashboards-functional-test repo in a tmp folder. Then move the required cypress tests in and run the bwc tests. partically solved: opensearch-project/opensearch-build#705 Signed-off-by: Anan Zhuang <[email protected]> * change file name to match opensearch-build script_finder. Signed-off-by: Anan Zhuang <[email protected]>
Description
This script is used to run bwc tests on a remote cluster.
It will first pull opensearch-dashboards-functional-test
repo in a tmp folder. Then move the required cypress tests
in and run the bwc tests.
partically solved:
opensearch-project/opensearch-build#705
Signed-off-by: Anan Zhuang [email protected]
Check List