Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on 8723 comment #8733

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 29, 2024

Description

This is a follow up fix for the comment:
#8723 (comment)

Issues Resolved

NA

Screenshot

Screenshot 2024-10-28 at 7 08 21 PM

Testing the changes

NA

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

This is a follow up fix for the comment:
opensearch-project#8723 (comment)

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh added the v2.18.0 label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (53e8404) to head (c398a09).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ns/data/public/query/query_string/query_history.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8733      +/-   ##
==========================================
+ Coverage   60.71%   60.74%   +0.02%     
==========================================
  Files        3798     3798              
  Lines       90662    90662              
  Branches    14260    14260              
==========================================
+ Hits        55047    55074      +27     
+ Misses      32163    32138      -25     
+ Partials     3452     3450       -2     
Flag Coverage Δ
Linux_1 29.06% <0.00%> (ø)
Linux_2 56.39% <ø> (?)
Linux_3 37.58% <77.77%> (+<0.01%) ⬆️
Linux_4 29.83% <0.00%> (ø)
Windows_1 29.08% <0.00%> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.58% <77.77%> (+<0.01%) ⬆️
Windows_4 29.83% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc added v2.19.0 and removed v2.18.0 labels Oct 29, 2024
@ashwin-pc ashwin-pc merged commit aaae87b into opensearch-project:main Oct 29, 2024
80 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8733-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aaae87b7ec367ac5bd19238ac82f2bdb27090b94
# Push it to GitHub
git push --set-upstream origin backport/backport-8733-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8733-to-2.x.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Oct 29, 2024
)

This is a backport PR for opensearch-project#8733

The original PR is a follow up fix for the comment:
opensearch-project#8723 (comment)

Signed-off-by: Anan Zhuang <[email protected]>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
This is a follow up fix for the comment:
opensearch-project#8723 (comment)

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit that referenced this pull request Oct 30, 2024
This is a backport PR for #8733

The original PR is a follow up fix for the comment:
#8723 (comment)

Signed-off-by: Anan Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover for discover reinvent discover-next distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants