-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up on 8723 comment #8733
Conversation
This is a follow up fix for the comment: opensearch-project#8723 (comment) Signed-off-by: Anan Zhuang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8733 +/- ##
==========================================
+ Coverage 60.71% 60.74% +0.02%
==========================================
Files 3798 3798
Lines 90662 90662
Branches 14260 14260
==========================================
+ Hits 55047 55074 +27
+ Misses 32163 32138 -25
+ Partials 3452 3450 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8733-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aaae87b7ec367ac5bd19238ac82f2bdb27090b94
# Push it to GitHub
git push --set-upstream origin backport/backport-8733-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
) This is a backport PR for opensearch-project#8733 The original PR is a follow up fix for the comment: opensearch-project#8723 (comment) Signed-off-by: Anan Zhuang <[email protected]>
This is a follow up fix for the comment: opensearch-project#8723 (comment) Signed-off-by: Anan Zhuang <[email protected]>
This is a backport PR for #8733 The original PR is a follow up fix for the comment: #8723 (comment) Signed-off-by: Anan Zhuang <[email protected]>
Description
This is a follow up fix for the comment:
#8723 (comment)
Issues Resolved
NA
Screenshot
Testing the changes
NA
Changelog
Check List
yarn test:jest
yarn test:jest_integration