Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace]feat: add collaborator table to workspace detail page #8528

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 98df4dd from #8501.

* feat: add collaborator table

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #8501 created/updated

* Changeset file for PR #8501 created/updated

* remove extra comment and add test for button

Signed-off-by: tygao <[email protected]>

* combine onChange

Signed-off-by: tygao <[email protected]>

* update table

Signed-off-by: tygao <[email protected]>

* test: add tests for table

Signed-off-by: tygao <[email protected]>

* address comments

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 98df4dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 69.09091% with 34 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (6730e0b) to head (1e8272d).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ts/workspace_form/workspace_collaborator_table.tsx 62.33% 24 Missing and 5 partials ⚠️
...ic/components/workspace_form/use_workspace_form.ts 50.00% 3 Missing ⚠️
...ponents/workspace_form/add_collaborator_button.tsx 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8528      +/-   ##
==========================================
- Coverage   61.02%   61.02%   -0.01%     
==========================================
  Files        3766     3768       +2     
  Lines       89428    89520      +92     
  Branches    13992    14006      +14     
==========================================
+ Hits        54573    54629      +56     
- Misses      31457    31487      +30     
- Partials     3398     3404       +6     
Flag Coverage Δ
Linux_1 29.01% <69.09%> (+0.04%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.78% <ø> (+<0.01%) ⬆️
Linux_4 30.03% <ø> (ø)
Windows_1 29.02% <69.09%> (+0.04%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.78% <ø> (ø)
Windows_4 30.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit effd6d5 into 2.x Oct 9, 2024
68 of 70 checks passed
@github-actions github-actions bot deleted the backport/backport-8501-to-2.x branch October 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants