Update sample data page UI when useUpdatedUX enabled #8291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8291 +/- ##
==========================================
- Coverage 60.92% 60.90% -0.03%
==========================================
Files 3749 3749
Lines 89021 89034 +13
Branches 13899 13899
==========================================
- Hits 54236 54222 -14
- Misses 31423 31494 +71
+ Partials 3362 3318 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
wanglam
requested review from
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Hailong-am
reviewed
Sep 24, 2024
Comment on lines
+174
to
+182
| return await renderApp( | ||
| params.element, | ||
| { | ||
| ...coreStart, | ||
| navigation, | ||
| setHeaderActionMenu: params.setHeaderActionMenu, | ||
| }, | ||
| params.history | ||
| ); |
There was a problem hiding this comment.
do we need this change for home page?
There was a problem hiding this comment.
The page will be broken if we visit /app/home#/tutorial_directory directly. To align with the latest design, I think we should render the same UI for this entry.
SuZhou-Joe
approved these changes
Sep 29, 2024
ruanyl
approved these changes
Sep 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
* Update sample data page with latest UI when useUpdatedUX enabled Signed-off-by: Lin Wang <[email protected]> * Fix crashed in home page Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8291 created/updated * Reduce spacing between sample data cards Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c1a349a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Update sample data page with latest UI when useUpdatedUX enabled * Fix crashed in home page * Changeset file for PR #8291 created/updated * Reduce spacing between sample data cards --------- (cherry picked from commit c1a349a) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…ect#8291) (opensearch-project#8377) * Update sample data page with latest UI when useUpdatedUX enabled * Fix crashed in home page * Changeset file for PR opensearch-project#8291 created/updated * Reduce spacing between sample data cards --------- (cherry picked from commit c1a349a) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for updating the sample data page UI when useUpdatedUX enabled. It mainly includes below changes:
Issues Resolved
#8312
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignoreconfig/opensearch_dashboards.ymlyarn start --no-base-pathChangelog
Check List
yarn test:jestyarn test:jest_integration