fix: fix overlay offsets on pages with feature header #8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <[email protected]>
virajsanghvi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
sejli,
joshuali925 and
huyaboo
as code owners
AMoo-Miki
approved these changes
Sep 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8223 +/- ##
=======================================
Coverage 64.05% 64.05%
=======================================
Files 3741 3741
Lines 88635 88635
Branches 13803 13804 +1
=======================================
+ Hits 56772 56775 +3
+ Misses 31265 31262 -3
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
approved these changes
Sep 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* fix: fix overlay offsets on pages with feature header Signed-off-by: Viraj Sanghvi <[email protected]> * Changeset file for PR #8223 created/updated --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2ffe62a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* fix: fix overlay offsets on pages with feature header Signed-off-by: Viraj Sanghvi <[email protected]> * Changeset file for PR #8223 created/updated --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2ffe62a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 19, 2024
* fix: fix overlay offsets on pages with feature header * Changeset file for PR #8223 created/updated --------- (cherry picked from commit 2ffe62a) Signed-off-by: Viraj Sanghvi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When overlays are positioned, the body becomes positioned relative. The margin on the feature page header vertically offset the body, which caused absolutely positioned overlays (like tooltips) to be 12px lower than expected. Using padding avoids this offset.
Issues Resolved
N/A
Screenshot
Before:
After:
This should resolve the dropdown issue we were seeing as well.
Testing the changes
Tested locally
Changelog
Check List
yarn test:jestyarn test:jest_integration