Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page Header]Make saved queries a context menu item in filter options instead of a button #7788

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Aug 21, 2024

Description

  • remove the save query button
  • create a new menu button called "saved queries" and make it conditionally render with newhome toggle
  • remove popover header "Filters"
  • add separator horizontal rule

Issues Resolved

Screenshot

image

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (b4ae264) to head (158fd19).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7788   +/-   ##
=======================================
  Coverage   63.79%   63.80%           
=======================================
  Files        3656     3656           
  Lines       81190    81205   +15     
  Branches    12945    12949    +4     
=======================================
+ Hits        51794    51811   +17     
+ Misses      26217    26214    -3     
- Partials     3179     3180    +1     
Flag Coverage Δ
Linux_1 30.08% <ø> (+0.02%) ⬆️
Linux_2 55.87% <ø> (ø)
Linux_3 40.42% <100.00%> (ø)
Linux_4 31.28% <ø> (ø)
Windows_1 30.09% <ø> (+0.02%) ⬆️
Windows_2 55.82% <ø> (ø)
Windows_3 40.42% <100.00%> (ø)
Windows_4 31.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu merged commit 9d692ef into opensearch-project:main Aug 21, 2024
75 of 76 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 21, 2024
… instead of a button (#7788)

(cherry picked from commit 9d692ef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu pushed a commit that referenced this pull request Aug 21, 2024
… instead of a button (#7788) (#7790)

(cherry picked from commit 9d692ef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor enhancement New feature or request Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants