Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location #7758

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Aug 19, 2024

Description

SQL autocomplete feature

  • Move registration
  • Change interface to add details as type

Issues Resolved

N/A

Screenshot

Testing the changes

Changelog

  • feat: Minor interface change and move suggestion provider registration location

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@mengweieric mengweieric changed the title [AUTOCOMPLETE - SQL] Minor interface change and move suggestion provider registration location [Autocomplete - SQL] Minor interface change and move suggestion provider registration location Aug 19, 2024
@mengweieric mengweieric changed the title [Autocomplete - SQL] Minor interface change and move suggestion provider registration location [Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/autocomplete-2.0@389ad1b). Learn more about missing BASE report.

Files Patch % Lines
...ata/public/antlr/opensearch_sql/code_completion.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             feature/autocomplete-2.0    #7758   +/-   ##
===========================================================
  Coverage                            ?   63.82%           
===========================================================
  Files                               ?     3651           
  Lines                               ?    80994           
  Branches                            ?    12895           
===========================================================
  Hits                                ?    51698           
  Misses                              ?    26128           
  Partials                            ?     3168           
Flag Coverage Δ
Linux_1 30.08% <33.33%> (?)
Linux_2 55.89% <ø> (?)
Linux_3 40.44% <33.33%> (?)
Linux_4 31.32% <33.33%> (?)
Windows_1 30.09% <33.33%> (?)
Windows_2 55.85% <ø> (?)
Windows_3 40.44% <33.33%> (?)
Windows_4 31.32% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 23798a0 into opensearch-project:feature/autocomplete-2.0 Aug 20, 2024
56 of 67 checks passed
paulstn pushed a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Aug 27, 2024
…d move suggestion provider registration location (opensearch-project#7758)

* add table/source as prefix to suggested fields

Signed-off-by: Eric <[email protected]>

* add type to column

Signed-off-by: Eric <[email protected]>

* move registeration to osd/monaco

Signed-off-by: Eric <[email protected]>

* add detail

Signed-off-by: Eric <[email protected]>

* Changeset file for PR opensearch-project#7758 created/updated

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Aug 30, 2024
…d move suggestion provider registration location (opensearch-project#7758)

* add table/source as prefix to suggested fields

Signed-off-by: Eric <[email protected]>

* add type to column

Signed-off-by: Eric <[email protected]>

* move registeration to osd/monaco

Signed-off-by: Eric <[email protected]>

* add detail

Signed-off-by: Eric <[email protected]>

* Changeset file for PR opensearch-project#7758 created/updated

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Aug 30, 2024
…d move suggestion provider registration location (opensearch-project#7758)

* add table/source as prefix to suggested fields

Signed-off-by: Eric <[email protected]>

* add type to column

Signed-off-by: Eric <[email protected]>

* move registeration to osd/monaco

Signed-off-by: Eric <[email protected]>

* add detail

Signed-off-by: Eric <[email protected]>

* Changeset file for PR opensearch-project#7758 created/updated

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Aug 30, 2024
* [Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location (#7758)

* add table/source as prefix to suggested fields

Signed-off-by: Eric <[email protected]>

* add type to column

Signed-off-by: Eric <[email protected]>

* move registeration to osd/monaco

Signed-off-by: Eric <[email protected]>

* add detail

Signed-off-by: Eric <[email protected]>

* Changeset file for PR #7758 created/updated

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [Autocomplete] PPL Autocomplete (#7810)

* add initial ppl autocomplete

Signed-off-by: Eric <[email protected]>

* untrack .antlr files

Signed-off-by: Eric <[email protected]>

* ignore intermediate grammar auto-gen files

Signed-off-by: Eric <[email protected]>

* add rules and related functionalities

Signed-off-by: Eric <[email protected]>

* Changeset file for PR #7810 created/updated

* Changeset file for PR #7810 created/updated

* minor comment cleanning

Signed-off-by: Eric <[email protected]>

* add ppl generation command

Signed-off-by: Eric <[email protected]>

* add rules

Signed-off-by: Eric <[email protected]>

* correct typo

Signed-off-by: Eric <[email protected]>

* fix inserting text issue

Signed-off-by: Eric <[email protected]>

* remove colon for PPL field

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* small interface updates

Signed-off-by: Paul Sebastian <[email protected]>

* small type update

Signed-off-by: Paul Sebastian <[email protected]>

* make inclusion for pipe, comma, and equal tokens

Signed-off-by: Paul Sebastian <[email protected]>

* refactor and generalize field fetcher for dql and ppl, including details

Signed-off-by: Paul Sebastian <[email protected]>

* use field fetching util for sql and update sugg detail for dql

Signed-off-by: Paul Sebastian <[email protected]>

* detail for ppl

Signed-off-by: Paul Sebastian <[email protected]>

* create range parameter to help identify suggestions with whitespace, implemented dql value WS suggs

Signed-off-by: Paul Sebastian <[email protected]>

* single line editor overflow initial override for sugg window

Signed-off-by: Paul Sebastian <[email protected]>

* update dql tests to account for details and value ranges

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
* [Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location (#7758)

* add table/source as prefix to suggested fields

Signed-off-by: Eric <[email protected]>

* add type to column

Signed-off-by: Eric <[email protected]>

* move registeration to osd/monaco

Signed-off-by: Eric <[email protected]>

* add detail

Signed-off-by: Eric <[email protected]>

* Changeset file for PR #7758 created/updated

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [Autocomplete] PPL Autocomplete (#7810)

* add initial ppl autocomplete

Signed-off-by: Eric <[email protected]>

* untrack .antlr files

Signed-off-by: Eric <[email protected]>

* ignore intermediate grammar auto-gen files

Signed-off-by: Eric <[email protected]>

* add rules and related functionalities

Signed-off-by: Eric <[email protected]>

* Changeset file for PR #7810 created/updated

* Changeset file for PR #7810 created/updated

* minor comment cleanning

Signed-off-by: Eric <[email protected]>

* add ppl generation command

Signed-off-by: Eric <[email protected]>

* add rules

Signed-off-by: Eric <[email protected]>

* correct typo

Signed-off-by: Eric <[email protected]>

* fix inserting text issue

Signed-off-by: Eric <[email protected]>

* remove colon for PPL field

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* small interface updates

Signed-off-by: Paul Sebastian <[email protected]>

* small type update

Signed-off-by: Paul Sebastian <[email protected]>

* make inclusion for pipe, comma, and equal tokens

Signed-off-by: Paul Sebastian <[email protected]>

* refactor and generalize field fetcher for dql and ppl, including details

Signed-off-by: Paul Sebastian <[email protected]>

* use field fetching util for sql and update sugg detail for dql

Signed-off-by: Paul Sebastian <[email protected]>

* detail for ppl

Signed-off-by: Paul Sebastian <[email protected]>

* create range parameter to help identify suggestions with whitespace, implemented dql value WS suggs

Signed-off-by: Paul Sebastian <[email protected]>

* single line editor overflow initial override for sugg window

Signed-off-by: Paul Sebastian <[email protected]>

* update dql tests to account for details and value ranges

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 0245540)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Aug 30, 2024
* [Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location (#7758)

* add table/source as prefix to suggested fields



* add type to column



* move registeration to osd/monaco



* add detail



* Changeset file for PR #7758 created/updated

---------




* [Autocomplete] PPL Autocomplete (#7810)

* add initial ppl autocomplete



* untrack .antlr files



* ignore intermediate grammar auto-gen files



* add rules and related functionalities



* Changeset file for PR #7810 created/updated

* Changeset file for PR #7810 created/updated

* minor comment cleanning



* add ppl generation command



* add rules



* correct typo



* fix inserting text issue



* remove colon for PPL field



---------




* small interface updates



* small type update



* make inclusion for pipe, comma, and equal tokens



* refactor and generalize field fetcher for dql and ppl, including details



* use field fetching util for sql and update sugg detail for dql



* detail for ppl



* create range parameter to help identify suggestions with whitespace, implemented dql value WS suggs



* single line editor overflow initial override for sugg window



* update dql tests to account for details and value ranges



---------





(cherry picked from commit 0245540)

Signed-off-by: Eric <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants