[Rename] Refactored src/cli_keystore/*#76
Merged
boktorbb merged 2 commits intoopensearch-project:dashboardsfrom Mar 13, 2021
mihirsoni:src/cli_keystore
Merged
[Rename] Refactored src/cli_keystore/*#76boktorbb merged 2 commits intoopensearch-project:dashboardsfrom mihirsoni:src/cli_keystore
boktorbb merged 2 commits intoopensearch-project:dashboardsfrom
mihirsoni:src/cli_keystore
Conversation
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
reviewed
Mar 5, 2021
kavilla
reviewed
Mar 5, 2021
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] Refactored src/cli_keystore/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/cli_keystore/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/cli_keystore/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Aug 11, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 27, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 27, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 9, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 9, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 13, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 17, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 18, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 27, 2023
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Feb 27, 2024
* add workspace filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> * workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * managment workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Saved objects page change (opensearch-project#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> filters Signed-off-by: Hailong Cui <ihailong@amazon.com> remove copy related Signed-off-by: Hailong Cui <ihailong@amazon.com> revert index pattern chagne Signed-off-by: Hailong Cui <ihailong@amazon.com> add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> remove permissions Signed-off-by: Hailong Cui <ihailong@amazon.com> pick up workspaceEnabled changes Signed-off-by: Hailong Cui <ihailong@amazon.com> Use formatUrlWithWorkspaceId to foramt inAppURL for saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> fix unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> Remove workspacesEnabledSubscription Signed-off-by: Hailong Cui <ihailong@amazon.com> Add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> Add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Issue #, if available: #37
Description of changes: [Rename] Refactored src/cli_keystore/*
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.