Skip to content

[MDS] Fix the hide local cluster config #7497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2024
Merged

[MDS] Fix the hide local cluster config #7497

merged 3 commits into from
Jul 26, 2024

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Jul 25, 2024 •
edited
Loading

Description

The datasource picker in zero etl datasource panel should repect the configuration of data_source.hideLocalCluster: true

Issues Resolved

Screenshot

Screen.Recording.2024-07-25.at.4.54.30.PM.mov

Testing the changes

Changelog

  • fix: [MDS] Fix the hide local cluster config

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.11%. Comparing base (6db84ea) to head (78c804a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7497   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files        3616     3616           
  Lines       78759    78759           
  Branches    12453    12453           
=======================================
  Hits        50497    50497           
- Misses      25206    25207    +1     
+ Partials     3056     3055    -1
Flag Coverage Δ
Linux_1 30.91% <ø> (ø)
Linux_2 55.59% <ø> (ø)
Linux_3 40.63% <ø> (-0.01%) ⬇️
Linux_4 31.77% <ø> (ø)
Windows_1 30.92% <ø> (ø)
Windows_2 55.54% <ø> (ø)
Windows_3 40.65% <ø> (+<0.01%) ⬆️
Windows_4 31.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit e24e535 into opensearch-project:main Jul 26, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
@github-actions @opensearch-changeset-bot
[MDS] Fix the hide local cluster config (#7497)
29ee636 
* Fix the local cluster config

Signed-off-by: Ryan Liang <[email protected]>

* Fix the local cluster config and add test

Signed-off-by: Ryan Liang <[email protected]>

* Changeset file for PR #7497 created/updated

---------

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit e24e535)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 26, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
@github-actions @opensearch-changeset-bot
[MDS] Fix the hide local cluster config (#7497)
c40342c 
* Fix the local cluster config

Signed-off-by: Ryan Liang <[email protected]>

* Fix the local cluster config and add test

Signed-off-by: Ryan Liang <[email protected]>

* Changeset file for PR #7497 created/updated

---------

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit e24e535)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 26, 2024
Merged
zhongnansu pushed a commit that referenced this pull request Jul 26, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[MDS] Fix the hide local cluster config (#7497) (#7506)
eb99c5c 
* Fix the local cluster config



* Fix the local cluster config and add test



* Changeset file for PR #7497 created/updated

---------



(cherry picked from commit e24e535)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Jul 26, 2024
@RyanL1997 @opensearch-changeset-bot @paulstn
[MDS] Fix the hide local cluster config (opensearch-project#7497)
1491c58 
* Fix the local cluster config

Signed-off-by: Ryan Liang <[email protected]>

* Fix the local cluster config and add test

Signed-off-by: Ryan Liang <[email protected]>

* Changeset file for PR opensearch-project#7497 created/updated

---------

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
zhyuanqi pushed a commit that referenced this pull request Jul 29, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @BionIT
[MDS] Fix the hide local cluster config (#7497) (#7507)
36f1a1d 
* Fix the local cluster config



* Fix the local cluster config and add test



* Changeset file for PR #7497 created/updated

---------



(cherry picked from commit e24e535)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <[email protected]>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
@RyanL1997 @opensearch-changeset-bot @Qxisylolo
[MDS] Fix the hide local cluster config (opensearch-project#7497)
50aa1f4 
* Fix the local cluster config

Signed-off-by: Ryan Liang <[email protected]>

* Fix the local cluster config and add test

Signed-off-by: Ryan Liang <[email protected]>

* Changeset file for PR opensearch-project#7497 created/updated

---------

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@RyanL1997 RyanL1997 mentioned this pull request Sep 6, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BionIT BionIT BionIT approved these changes

@zhyuanqi zhyuanqi zhyuanqi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanL1997 @BionIT @zhyuanqi