Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns #7420

Merged
merged 5 commits into from
Jul 23, 2024
Merged

[Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns #7420

merged 5 commits into from
Jul 23, 2024

Conversation

ZilongX
Copy link
Collaborator

@ZilongX ZilongX commented Jul 23, 2024 •
edited
Loading

Description

  • This one adds new returned fields datasourceversion and installedplugins in DataSourceView
  • This also fix the current filter logic to ensure filter is applied as expected

Issues Resolved

#7099

Changelog

  • fix: [Version Decoupling] Add data source version and installed plugins in data source viewer returns

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ZilongX added 3 commits July 23, 2024 15:11
@ZilongX
[Multiple Datasource][Version Decoupling] Add data source version and…
f55e3cc 
… installed plugins in data source viewer returns

Signed-off-by: Zilong Xia <[email protected]>
@ZilongX
[Multiple Datasource][Version Decoupling] Add data source version and…
6e9f085 
… installed plugins in data source viewer returns

Signed-off-by: Zilong Xia <[email protected]>
@ZilongX
Lint fix
1f445ef 
Signed-off-by: Zilong Xia <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Entry Too Long

Entry is 118 characters long, which is 18 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

@ZilongX @BionIT
Update src/plugins/data_source_management/public/components/data_sour…
f324748 
…ce_view/data_source_view.tsx

Co-authored-by: Lu Yu <[email protected]>
Signed-off-by: ZilongX <[email protected]>
BionIT
BionIT previously approved these changes Jul 23, 2024
View reviewed changes
@ZilongX ZilongX merged commit 2bbd9fe into opensearch-project:main Jul 23, 2024
53 of 54 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions @BionIT @opensearch-changeset-bot
[Multiple Datasource][Version Decoupling] Add data source version and…
9dd3b97 
… installed plugins in data source viewer returns (#7420)

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns

Signed-off-by: Zilong Xia <[email protected]>

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns

Signed-off-by: Zilong Xia <[email protected]>

* Lint fix

Signed-off-by: Zilong Xia <[email protected]>

* Update src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx

Co-authored-by: Lu Yu <[email protected]>
Signed-off-by: ZilongX <[email protected]>

* Changeset file for PR #7420 created/updated

---------

Signed-off-by: Zilong Xia <[email protected]>
Signed-off-by: ZilongX <[email protected]>
Co-authored-by: Lu Yu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2bbd9fe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions @BionIT @opensearch-changeset-bot
[Multiple Datasource][Version Decoupling] Add data source version and…
fe0bd5b 
… installed plugins in data source viewer returns (#7420)

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns

Signed-off-by: Zilong Xia <[email protected]>

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns

Signed-off-by: Zilong Xia <[email protected]>

* Lint fix

Signed-off-by: Zilong Xia <[email protected]>

* Update src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx

Co-authored-by: Lu Yu <[email protected]>
Signed-off-by: ZilongX <[email protected]>

* Changeset file for PR #7420 created/updated

---------

Signed-off-by: Zilong Xia <[email protected]>
Signed-off-by: ZilongX <[email protected]>
Co-authored-by: Lu Yu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2bbd9fe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Merged
ZilongX pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
@BionIT @opensearch-changeset-bot
[Multiple Datasource][Version Decoupling] Add data source version and…
db6d2a5 
… installed plugins in data source viewer returns (#7420) (#7421)

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns



* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns



* Lint fix



* Update src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx




* Changeset file for PR #7420 created/updated

---------





(cherry picked from commit 2bbd9fe)

Signed-off-by: Zilong Xia <[email protected]>
Signed-off-by: ZilongX <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ZilongX pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
@BionIT @opensearch-changeset-bot
[Multiple Datasource][Version Decoupling] Add data source version and…
812d92b 
… installed plugins in data source viewer returns (#7420) (#7422)

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns



* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in data source viewer returns



* Lint fix



* Update src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx




* Changeset file for PR #7420 created/updated

---------





(cherry picked from commit 2bbd9fe)

Signed-off-by: Zilong Xia <[email protected]>
Signed-off-by: ZilongX <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyuanqi zhyuanqi zhyuanqi approved these changes

@BionIT BionIT BionIT approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 multiple datasource multiple datasource project version decoupling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZilongX @BionIT @zhyuanqi