-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Recover data source management in workspace #7296
Conversation
Signed-off-by: tygao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7296 +/- ##
=======================================
Coverage 67.50% 67.50%
=======================================
Files 3501 3501
Lines 69343 69343
Branches 11305 11305
=======================================
+ Hits 46808 46812 +4
+ Misses 19779 19776 -3
+ Partials 2756 2755 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @raintygao I think we can close this PR because: |
Pick up the main and re-running all checks |
So do we still need this change to be merged as part of 2.16.0 ? |
Yes, after discussing we can merge it in 2.16 as this is a very tiny change. CC @SuZhou-Joe @ruanyl |
* recover DSM in workspace Signed-off-by: tygao <[email protected]> * Changeset file for PR #7296 created/updated --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <[email protected]> (cherry picked from commit 352682b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* recover DSM in workspace * Changeset file for PR #7296 created/updated --------- (cherry picked from commit 352682b) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <[email protected]>
Description
Data source is a global level saved object, so we disable data source management when in workspace.
For now, data source is a workspace level object, so we should recover data source management in workspace and disable create/update/delete operation in frontend(#7214 has implemented).
Screenshot
Testing the changes
Enter a workspace then you can visit data source management then will see workspace level data source objects and there is not entry for creating/updating/deleting.
Changelog
Check List
yarn test:jest
yarn test:jest_integration