-
Notifications
You must be signed in to change notification settings - Fork 996
[Look&Feel] Update Popover Padding Size #7200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Look&Feel] Update Popover Padding Size #7200
Conversation
Know this is a draft, but one comment - do you know why the padding for "Syntax" look condensed in the after? I'm guessing we're not using the component correctly? |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7200 +/- ##
==========================================
- Coverage 67.56% 67.55% -0.01%
==========================================
Files 3469 3469
Lines 68479 68479
Branches 11130 11130
==========================================
- Hits 46266 46264 -2
- Misses 19511 19512 +1
- Partials 2702 2703 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM ,but can you get checks passing so I can approve? For changelog, think you want to install https://github.com/apps/opensearch-changeset-bot in your repo so it automatically gets created here |
Restarted failed test to see if it passes |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
e75e6e0
to
f0c3436
Compare
Signed-off-by: Dan Dong <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7200-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b422791347c22029f0cf155ff24492d0ea9e3c8d
# Push it to GitHub
git push --set-upstream origin backport/backport-7200-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Description
Set popover padding size to small for instances of non-context menu popovers. Did not change popovers that had no padding to begin with.
Screenshots
Changelog
Check List
yarn test:jest
yarn test:jest_integration