Skip to content

[Docs] Added TESTING.md#713

Merged
kavilla merged 1 commit intoopensearch-project:mainfrom
kavilla:avillk/testing
Aug 12, 2021
Merged

[Docs] Added TESTING.md#713
kavilla merged 1 commit intoopensearch-project:mainfrom
kavilla:avillk/testing

Conversation

@kavilla
Copy link
Copy Markdown
Member

@kavilla kavilla commented Aug 7, 2021

Description

Adding TESTING.md to the project as referenced in the README.

The content is some general information about testing and should not
be considered exhaustive.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

#667

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Adding TESTING.md to the project as referenced in the README.

The content is some general information about testing and should not
be considered exhaustive.

Issue resolved:
opensearch-project#667

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla added bug Something isn't working docs Improvements or additions to documentation v1.1.0 labels Aug 7, 2021
@kavilla kavilla linked an issue Aug 7, 2021 that may be closed by this pull request
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   DCO Check Passed cf73262

Copy link
Copy Markdown
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise LGTM!

* End-to-end tests (e2e): functional tests that verify behavior in a web browser.

# Requirements
* Install the latest NodeJS, [NPM](https://www.npmjs.com/get-npm) and [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to explicitly install npm? I haven't needed to do so.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge in now since the page 404s but if we can see if people have issues with this. If so we can update this section.

@kavilla kavilla merged commit ea9e742 into opensearch-project:main Aug 12, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Aug 12, 2021
Adding TESTING.md to the project as referenced in the README.

The content is some general information about testing and should not
be considered exhaustive.

Issue resolved:
opensearch-project#667

Backport PR:
opensearch-project#713

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this pull request Aug 12, 2021
5 tasks
kavilla added a commit that referenced this pull request Aug 18, 2021
Adding TESTING.md to the project as referenced in the README.

The content is some general information about testing and should not
be considered exhaustive.

Issue resolved:
#667

Backport PR:
#713

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla deleted the avillk/testing branch August 24, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working docs Improvements or additions to documentation v1.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Testing page not found

4 participants