-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 815d2bd7c612450e2a15a6543c7e74558adf4a81 "[Manual Backport 2.x] Feat (core): Make theme settings user-specific and user-configurable (#5652) (#6681)" #6978
Conversation
Signed-off-by: Huan Jiang <[email protected]>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
@joshuarrrr @ashwin-pc @ananzh @BionIT |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6978 +/- ##
==========================================
+ Coverage 67.49% 67.56% +0.07%
==========================================
Files 3442 3441 -1
Lines 67868 67805 -63
Branches 11024 11017 -7
==========================================
+ Hits 45805 45812 +7
+ Misses 19399 19332 -67
+ Partials 2664 2661 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6978-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87d9ee080699c4dcdd3783c6276a3e5762f45629
# Push it to GitHub
git push --set-upstream origin backport/backport-6978-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
This reverts commit 815d2bd on 2.x branch
We are lack of test coverage to release this feature. It should be ok to leave it in main. There is debt whether we should keep in 2.x. Since there is no clear plan for the test, the change is big. To avoid manual revert on every release (like what we did in 2.14), we'd like to revert on 2.x.