-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Feat add use cases to workspace form #6887
[Workspace]Feat add use cases to workspace form #6887
Conversation
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6887 +/- ##
=======================================
Coverage 67.42% 67.43%
=======================================
Files 3445 3445
Lines 67827 67818 -9
Branches 11036 11028 -8
=======================================
- Hits 45735 45732 -3
+ Misses 19424 19420 -4
+ Partials 2668 2666 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @wanglam, is this PR targeting 2.15 or 2.16? |
Hi @BionIT , this PR is target for 2.15. Since this PR still need UX approve. I will change to ready for review once UX finalized. |
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
@wanglam UX looks good to me |
Hi @Flyingliuhub @ruanyl @SuZhou-Joe , I've updated the latest UI and addressed the comments. Could you help me take a look? |
@wanglam seems the test failed for snapshot checking. Could you please fix that? |
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
@SuZhou-Joe Thanks for point out this. I've fixed all the test failed. Feel free to help me review it. |
* Add workspace use case to workspace form Signed-off-by: Lin Wang <[email protected]> * Remove feature selector in workspace form Signed-off-by: Lin Wang <[email protected]> * Show use cases in workspace list page Signed-off-by: Lin Wang <[email protected]> * Change direction for workspace use case selector Signed-off-by: Lin Wang <[email protected]> * Modify test cases for match use case Signed-off-by: Lin Wang <[email protected]> * Make use cases as a required field Signed-off-by: Lin Wang <[email protected]> * Update ui according feedbacks Signed-off-by: Lin Wang <[email protected]> * Add management feature to dashboards and visualize use cases Signed-off-by: Lin Wang <[email protected]> * Update latest feature relationships Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #6887 created/updated * Changeset file for PR #6887 created/updated * Update test case for workspace creator and updater Signed-off-by: Lin Wang <[email protected]> * Address unit test Signed-off-by: Lin Wang <[email protected]> * Add discover feature to all use case Signed-off-by: Lin Wang <[email protected]> * Add missing features to security analytics Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Add comment for workspace use cases map Signed-off-by: Lin Wang <[email protected]> * Update use case UI Signed-off-by: Lin Wang <[email protected]> * Remove the permissions tab Signed-off-by: Lin Wang <[email protected]> * Update breadcrum to Create a workspace Signed-off-by: Lin Wang <[email protected]> * Address ut failed Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 7be3e30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add workspace use case to workspace form * Remove feature selector in workspace form * Show use cases in workspace list page * Change direction for workspace use case selector * Modify test cases for match use case * Make use cases as a required field * Update ui according feedbacks * Add management feature to dashboards and visualize use cases * Update latest feature relationships * Changeset file for PR #6887 created/updated * Changeset file for PR #6887 created/updated * Update test case for workspace creator and updater * Address unit test * Add discover feature to all use case * Add missing features to security analytics * Address PR comments * Add comment for workspace use cases map * Update use case UI * Remove the permissions tab * Update breadcrum to Create a workspace * Address ut failed --------- (cherry picked from commit 7be3e30) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Description
Issues Resolved
#6902
Screenshot
Testing the changes
yarn osd bootstrap
config/opensearch_dashboards.yml
admin
user and visit workspace create pageChangelog
Check List
yarn test:jest
yarn test:jest_integration