Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Feat add use cases to workspace form #6887

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Jun 3, 2024

Description

  1. Add use case selector to workspace form
  2. Remove workspace feature selector
  3. Add use workspace column in workspace list

Issues Resolved

#6902

Screenshot

image
image
image

Testing the changes

  • Clone branch code and run yarn osd bootstrap
  • Add below configuration to config/opensearch_dashboards.yml
opensearchDashboards.dashboardAdmin.users: ['admin']
workspace.enabled: true
  • Login with admin user and visit workspace create page
  • Input name and select one or multi use cases
  • Click create workspace, then name and use cases will be saved
  • Click left menu, the related features will be displayed.

Changelog

  • feat: [Workspace]Add use cases to workspace form

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Jun 3, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.43%. Comparing base (fe443e9) to head (4caf213).
Report is 394 commits behind head on main.

Files with missing lines Patch % Lines
...rkspace/public/components/workspace_list/index.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6887   +/-   ##
=======================================
  Coverage   67.42%   67.43%           
=======================================
  Files        3445     3445           
  Lines       67827    67818    -9     
  Branches    11036    11028    -8     
=======================================
- Hits        45735    45732    -3     
+ Misses      19424    19420    -4     
+ Partials     2668     2666    -2     
Flag Coverage Δ
Linux_1 33.08% <98.41%> (-0.01%) ⬇️
Linux_2 55.06% <ø> (ø)
Linux_3 45.21% <ø> (?)
Linux_4 34.87% <ø> (ø)
Windows_1 33.10% <98.41%> (-0.01%) ⬇️
Windows_2 55.01% <ø> (ø)
Windows_3 45.22% <ø> (ø)
Windows_4 34.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam changed the title Feat add use cases to workspace form [Workspace]Feat add use cases to workspace form Jun 3, 2024
@BionIT
Copy link
Collaborator

BionIT commented Jun 3, 2024

Hi @wanglam, is this PR targeting 2.15 or 2.16?

@wanglam
Copy link
Contributor Author

wanglam commented Jun 4, 2024

Hi @BionIT , this PR is target for 2.15. Since this PR still need UX approve. I will change to ready for review once UX finalized.

@wanglam wanglam marked this pull request as ready for review June 5, 2024 02:04
ruanyl
ruanyl previously approved these changes Jun 6, 2024
SuZhou-Joe
SuZhou-Joe previously approved these changes Jun 6, 2024
@wanglam wanglam dismissed stale reviews from SuZhou-Joe and ruanyl via 9bc93db June 6, 2024 14:11
@lauralexis
Copy link

@wanglam UX looks good to me

@wanglam
Copy link
Contributor Author

wanglam commented Jun 6, 2024

Hi @Flyingliuhub @ruanyl @SuZhou-Joe , I've updated the latest UI and addressed the comments. Could you help me take a look?

Flyingliuhub
Flyingliuhub previously approved these changes Jun 6, 2024
@SuZhou-Joe
Copy link
Member

@wanglam seems the test failed for snapshot checking. Could you please fix that?

@wanglam
Copy link
Contributor Author

wanglam commented Jun 7, 2024

@wanglam seems the test failed for snapshot checking. Could you please fix that?

@SuZhou-Joe Thanks for point out this. I've fixed all the test failed. Feel free to help me review it.

@SuZhou-Joe SuZhou-Joe merged commit 7be3e30 into opensearch-project:main Jun 7, 2024
70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2024
* Add workspace use case to workspace form

Signed-off-by: Lin Wang <[email protected]>

* Remove feature selector in workspace form

Signed-off-by: Lin Wang <[email protected]>

* Show use cases in workspace list page

Signed-off-by: Lin Wang <[email protected]>

* Change direction for workspace use case selector

Signed-off-by: Lin Wang <[email protected]>

* Modify test cases for match use case

Signed-off-by: Lin Wang <[email protected]>

* Make use cases as a required field

Signed-off-by: Lin Wang <[email protected]>

* Update ui according feedbacks

Signed-off-by: Lin Wang <[email protected]>

* Add management feature to dashboards and visualize use cases

Signed-off-by: Lin Wang <[email protected]>

* Update latest feature relationships

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #6887 created/updated

* Changeset file for PR #6887 created/updated

* Update test case for workspace creator and updater

Signed-off-by: Lin Wang <[email protected]>

* Address unit test

Signed-off-by: Lin Wang <[email protected]>

* Add discover feature to all use case

Signed-off-by: Lin Wang <[email protected]>

* Add missing features to security analytics

Signed-off-by: Lin Wang <[email protected]>

* Address PR comments

Signed-off-by: Lin Wang <[email protected]>

* Add comment for workspace use cases map

Signed-off-by: Lin Wang <[email protected]>

* Update use case UI

Signed-off-by: Lin Wang <[email protected]>

* Remove the permissions tab

Signed-off-by: Lin Wang <[email protected]>

* Update breadcrum to Create a workspace

Signed-off-by: Lin Wang <[email protected]>

* Address ut failed

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit 7be3e30)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT pushed a commit that referenced this pull request Jun 7, 2024
* Add workspace use case to workspace form



* Remove feature selector in workspace form



* Show use cases in workspace list page



* Change direction for workspace use case selector



* Modify test cases for match use case



* Make use cases as a required field



* Update ui according feedbacks



* Add management feature to dashboards and visualize use cases



* Update latest feature relationships



* Changeset file for PR #6887 created/updated

* Changeset file for PR #6887 created/updated

* Update test case for workspace creator and updater



* Address unit test



* Add discover feature to all use case



* Add missing features to security analytics



* Address PR comments



* Add comment for workspace use cases map



* Update use case UI



* Remove the permissions tab



* Update breadcrum to Create a workspace



* Address ut failed



---------




(cherry picked from commit 7be3e30)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants