Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Chrome version until ChromeDriver's release pipeline is fixed #6630

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Apr 24, 2024

Description

ChromeDriver hasn't been doing a good job of keeping up with Chrome releases. This has broken our CI. Until confidence in the ChromeDriver release pipeline is restored, this change locks down the version of Chrome we use in our CI.

The process for identifying the version

  1. Look at the Stable column of Linux releases. Linux has a lot less releases than Windows.
  2. Hit the i next to the major version you want. From experience, the minor and patch versions don't matter in this process.
  3. Take note of Branch Base Position. In this case, I was looking for v122 and the number was 1250580.
  4. Open Chromium's snapshot repository for Windows and Linux. Allow the pages to finish loading the content which can take 15-30 seconds; there is an ugly spinner to let you know it is loading.
  5. Enter the Branch Base Position number you took note of on step 3 into the Filter boxes.
  6. Remove the right-most digit. It is unlikely that the Branch Base Position number actually matches a snapshot. We will need to look around that number to find an actual snapshot's Branch Base Position number. In this case my filter was 125058.
  7. Find one that exists in both Windows and Linux snapshots. In this case 1250586 was available in both.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (d2d410b) to head (e03dafc).
Report is 31 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6630       +/-   ##
===========================================
+ Coverage   32.93%   67.74%   +34.80%     
===========================================
  Files        2260     3403     +1143     
  Lines       45769    66607    +20838     
  Branches     7200    10827     +3627     
===========================================
+ Hits        15075    45121    +30046     
+ Misses      29984    18847    -11137     
- Partials      710     2639     +1929     
Flag Coverage Δ
Linux_1 33.05% <ø> (+0.11%) ⬆️
Linux_2 55.60% <ø> (?)
Linux_3 45.25% <ø> (?)
Linux_4 34.93% <ø> (?)
Windows_1 33.07% <ø> (?)
Windows_2 55.57% <ø> (?)
Windows_3 45.26% <ø> (?)
Windows_4 34.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki force-pushed the lockdown-chromedriver branch from 710884b to 50fefcb Compare April 24, 2024 23:00
ruanyl
ruanyl previously approved these changes Apr 25, 2024
@Hailong-am
Copy link
Collaborator

Seems that the detected chrome version is still 124 when test running.
https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8824397290/job/24226792008?pr=6630

 warn Failure while creating webdriver instance
     │ warn SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 122
     │      Current browser version is 124.0.6367.60 with binary path /opt/google/chrome/chrome
     │          at Object.throwDecodedError (/home/runner/work/OpenSearch-Dashboards/OpenSearch-Dashboards/node_modules/selenium-webdriver/lib/error.js:550:15)
     │          at parseHttpResponse (/home/runner/work/OpenSearch-Dashboards/OpenSearch-Dashboards/node_modules/selenium-webdriver/lib/http.js:565:13)
     │          at Executor.execute (/home/runner/work/OpenSearch-Dashboards/OpenSearch-Dashboards/node_modules/selenium-webdriver/lib/http.js:491:26)
     │          at processTicksAndRejections (node:internal/process/task_queues:95:5)

@AMoo-Miki
Copy link
Collaborator Author

@Hailong-am seems like the location of Chrome in GitHub images has changed.

Additionally, I didn't do a good job of copy-pasting as the Windows specific piece of the workflow was missing. Hopefully my latest iteration would be the last.

@AMoo-Miki
Copy link
Collaborator Author

Spoke too soon. Looks like I installed 124. Will have to go down to 122.

@AMoo-Miki AMoo-Miki force-pushed the lockdown-chromedriver branch from d47d7aa to e03dafc Compare April 25, 2024 03:16
@AMoo-Miki AMoo-Miki merged commit a5551b9 into opensearch-project:main Apr 25, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2024
…6630)

Signed-off-by: Miki <[email protected]>
(cherry picked from commit a5551b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Apr 25, 2024
…6630) (#6634)

(cherry picked from commit a5551b9)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
@BionIT BionIT added the v2.14.0 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants