-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock Chrome version until ChromeDriver's release pipeline is fixed #6630
Lock Chrome version until ChromeDriver's release pipeline is fixed #6630
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6630 +/- ##
===========================================
+ Coverage 32.93% 67.74% +34.80%
===========================================
Files 2260 3403 +1143
Lines 45769 66607 +20838
Branches 7200 10827 +3627
===========================================
+ Hits 15075 45121 +30046
+ Misses 29984 18847 -11137
- Partials 710 2639 +1929
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
710884b
to
50fefcb
Compare
Seems that the detected chrome version is still 124 when test running.
|
50fefcb
to
d47d7aa
Compare
@Hailong-am seems like the location of Chrome in GitHub images has changed. Additionally, I didn't do a good job of copy-pasting as the Windows specific piece of the workflow was missing. Hopefully my latest iteration would be the last. |
Spoke too soon. Looks like I installed 124. Will have to go down to 122. |
Signed-off-by: Miki <[email protected]>
d47d7aa
to
e03dafc
Compare
…6630) Signed-off-by: Miki <[email protected]> (cherry picked from commit a5551b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…6630) (#6634) (cherry picked from commit a5551b9) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
ChromeDriver hasn't been doing a good job of keeping up with Chrome releases. This has broken our CI. Until confidence in the ChromeDriver release pipeline is restored, this change locks down the version of Chrome we use in our CI.
The process for identifying the version
Stable
column of Linux releases. Linux has a lot less releases than Windows.i
next to the major version you want. From experience, the minor and patch versions don't matter in this process.Branch Base Position
. In this case, I was looking for v122 and the number was1250580
.Filter
boxes.125058
.1250586
was available in both.Changelog
Check List
yarn test:jest
yarn test:jest_integration