-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Hide dashboard overview #6625
Merged
SuZhou-Joe
merged 3 commits into
opensearch-project:main
from
yubonluo:main-hide-overview
Apr 24, 2024
Merged
[Workspace] Hide dashboard overview #6625
SuZhou-Joe
merged 3 commits into
opensearch-project:main
from
yubonluo:main-hide-overview
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
April 24, 2024 02:26
SuZhou-Joe
previously approved these changes
Apr 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6625 +/- ##
===========================================
+ Coverage 32.93% 67.71% +34.78%
===========================================
Files 2260 3403 +1143
Lines 45769 66609 +20840
Branches 7200 10827 +3627
===========================================
+ Hits 15075 45107 +30032
+ Misses 29984 18862 -11122
- Partials 710 2640 +1930
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Apr 24, 2024
SuZhou-Joe
approved these changes
Apr 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
* feat: hide dashboard overview Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6625 created/updated * Changeset file for PR #6625 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 17ce314) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 25, 2024
* feat: hide dashboard overview Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6625 created/updated * Changeset file for PR #6625 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 17ce314) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 25, 2024
* feat: hide dashboard overview * Changeset file for PR #6625 created/updated * Changeset file for PR #6625 created/updated --------- (cherry picked from commit 17ce314) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
* feat: hide dashboard overview Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#6625 created/updated * Changeset file for PR opensearch-project#6625 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User can not choose the feature of dashboard overview when create/update a workspace.
Issues Resolved
closes #6624
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration