[Workspace] Register a workspace dropdown menu at the top of left nav bar #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
BionIT
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
==========================================
+ Coverage 67.31% 67.33% +0.02%
==========================================
Files 3350 3351 +1
Lines 64993 65037 +44
Branches 10468 10474 +6
==========================================
+ Hits 43750 43793 +43
- Misses 18695 18697 +2
+ Partials 2548 2547 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Mar 15, 2024
| @@ -74,6 +74,7 @@ function createCoreSetupMock({ | |||
| } = {}) { | |||
| const mock = { | |||
| application: applicationServiceMock.createSetupContract(), | |||
| chrome: chromeServiceMock.createSetupContract(), | |||
There was a problem hiding this comment.
So nice to have this in core mock, have encountered type error in some test cases
SuZhou-Joe
previously approved these changes
Mar 15, 2024
ruanyl
changed the title
BionIT
reviewed
Mar 20, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Show resolved
Hide resolved
When workspace is enabled, the workspace plugin will register a workspace dropdown menu via `chrome.registerCollapsibleNavHeader` which displays a list of workspaces, links to create workspace page and workspace list page. Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
workspace-dropdown-selector-in-left-nav
branch
from
8b8d7c7 to
862ae3b
Compare
xinruiba
reviewed
Mar 21, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Show resolved
Hide resolved
|
Thanks for the change, overall looks good to me. |
BionIT
approved these changes
Mar 21, 2024
SuZhou-Joe
approved these changes
Mar 21, 2024
7 tasks
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6150-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2ed39f76c75bec843243ff85113485984102dbc
# Push it to GitHub
git push --set-upstream origin backport/backport-6150-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
ruanyl
added a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Apr 17, 2024
… bar (opensearch-project#6150) When workspace is enabled, the workspace plugin will register a workspace dropdown menu via `chrome.registerCollapsibleNavHeader` which displays a list of workspaces, links to create workspace page and workspace list page. --------- Signed-off-by: Yulong Ruan <[email protected]>
Flyingliuhub
pushed a commit
that referenced
this pull request
Apr 17, 2024
… bar (#6150) (#6505) When workspace is enabled, the workspace plugin will register a workspace dropdown menu via `chrome.registerCollapsibleNavHeader` which displays a list of workspaces, links to create workspace page and workspace list page. --------- Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When workspace is enabled, the workspace plugin will register a workspace dropdown menu via
chrome.registerCollapsibleNavHeaderwhich displays a list of workspaces, links to create workspace page and workspace list page.NOT IN THE SCOPE OF THIS PR
Issues Resolved
#6149
Screenshot
workspace.dropdown.mov
Testing the changes
Update OSD config with
workspace.enabled: true, and you will see the workspace dropdown menu on the top of the left nav bar.Check List
yarn test:jestyarn test:jest_integration