Chore (deps): remove ui-select angular dev dep #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Signed-off-by: Josh Romero <[email protected]>
ashwin-pc
approved these changes
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5660 +/- ##
=======================================
Coverage 67.02% 67.02%
=======================================
Files 3294 3294
Lines 63309 63309
Branches 10071 10071
=======================================
Hits 42435 42435
Misses 18430 18430
Partials 2444 2444
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
approved these changes
Jan 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Chore (deps): remove ui-select angular dev dep Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit 52981db) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Chore (deps): remove ui-select angular dev dep --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit 52981db) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this pull request
Feb 5, 2024
* Chore (deps): remove ui-select angular dev dep Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> Signed-off-by: yujin-emma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove residual angular dependency. Appears unused from code search, and I don't think it's usable without angular anyway.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration