Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MD] Add data source signing support #2547

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e3bbdef from #2510

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner October 11, 2022 16:44
@kavilla
Copy link
Member

kavilla commented Oct 11, 2022

@opensearch-project/opensearch-dashboards-core this commit in main should have included the details from #2510 in the commit description. If a community member doesn't utilize GitHub then they will lose some of the great insight @noCharger provided on the pull request and what know how we sign for multiple datasources.

REF to the impact of non-descriptive commits

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #2547 (e3bbdef) into 2.x (8b81f4b) will increase coverage by 0.01%.
The diff coverage is 63.90%.

❗ Current head e3bbdef differs from pull request most recent head db14cf1. Consider uploading reports for the commit db14cf1 to get more accurate results

@@            Coverage Diff             @@
##              2.x    #2547      +/-   ##
==========================================
+ Coverage   66.73%   66.74%   +0.01%     
==========================================
  Files        3200     3204       +4     
  Lines       60918    60988      +70     
  Branches     9255     9275      +20     
==========================================
+ Hits        40652    40706      +54     
- Misses      18051    18064      +13     
- Partials     2215     2218       +3     
Impacted Files Coverage Δ
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...-opensearch-archiver/src/lib/indices/test_stubs.ts 80.00% <ø> (ø)
...ed_tests_reporter/run_failed_tests_reporter_cli.ts 17.91% <0.00%> (ø)
...tional_test_runner/lib/config/fixtures/config.1.js 100.00% <ø> (ø)
...tional_test_runner/lib/config/fixtures/config.2.js 100.00% <ø> (ø)
..._test_runner/lib/config/fixtures/config.invalid.js 100.00% <ø> (ø)
src/cli/cluster/cluster_manager.ts 43.68% <ø> (ø)
src/core/public/chrome/chrome_service.tsx 91.66% <ø> (ø)
src/core/public/chrome/nav_links/nav_link.ts 66.66% <ø> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 94.54% <ø> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Add data source signing support
* Optimize error handling and logging
* Update wording on error message and readme

Signed-off-by: Louis Chu <lingzhichu.clz@gmail.com>
(cherry picked from commit e3bbdef)
@kristenTian kristenTian force-pushed the backport/backport-2510-to-2.x branch from db14cf1 to de722aa Compare October 12, 2022 23:43
@kristenTian kristenTian merged commit 0ee5413 into 2.x Oct 12, 2022
@github-actions github-actions bot deleted the backport/backport-2510-to-2.x branch October 12, 2022 23:47
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…earch-project#2547)

* Add data source signing support
* Optimize error handling and logging
* Update wording on error message and readme

Signed-off-by: Louis Chu <lingzhichu.clz@gmail.com>
(cherry picked from commit e3bbdef)

Co-authored-by: Louis Chu <lingzhichu.clz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants