Skip to content

[Build] Update .gitignore to include renamed files#168

Merged
mihirsoni merged 1 commit intoopensearch-project:dashboardsfrom
kavilla:update-gitignore
Mar 16, 2021
Merged

[Build] Update .gitignore to include renamed files#168
mihirsoni merged 1 commit intoopensearch-project:dashboardsfrom
kavilla:update-gitignore

Conversation

@kavilla
Copy link
Copy Markdown
Member

@kavilla kavilla commented Mar 16, 2021

Files were renamed but the .gitignore file was not updated so some files got ignored while being committed.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@odfe-release-bot
Copy link
Copy Markdown

❌   DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/dashboards b927f893aa762b5947415573eaca8769e5a8c3b7 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Copy link
Copy Markdown
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Copy Markdown
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihirsoni mihirsoni merged commit ce02603 into opensearch-project:dashboards Mar 16, 2021
@kavilla kavilla deleted the update-gitignore branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…ensearch-project#168)

* add data sources and remove workspace settings for management workspace



* remove special logic for reserved workspaces



* register dev tools into opensearch features category



* update snapshots



* add workspace settings to management workspace



---------


(cherry picked from commit 564e94e)

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants