[Rename] Refactored root directory files by mihirsoni · Pull Request #145 · opensearch-project/OpenSearch-Dashboards

mihirsoni · 2021-03-10T08:27:09Z

Issue #, if available: #37

Description of changes: Refactored root directory files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

.eslintignore

.eslintrc.js

boktorbb · 2021-03-10T23:13:46Z

.eslintrc.js

-    /**
-     * Files that require Elastic license headers instead of Apache 2.0 header
-     */
-    {
-      files: ['x-pack/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        '@kbn/eslint/require-license-header': [
-          'error',
-          {
-            license: ELASTIC_LICENSE_HEADER,
-          },
-        ],
-        '@kbn/eslint/disallow-license-headers': [
-          'error',
-          {
-            licenses: [
-              APACHE_2_0_LICENSE_HEADER,
-              SAFER_LODASH_SET_HEADER,
-              SAFER_LODASH_SET_LODASH_HEADER,
-              SAFER_LODASH_SET_DEFINITELYTYPED_HEADER,
-            ],
-          },
-        ],
-      },
-    },
-


why are these removed?

.eslintrc.js

FAQ.md

README.md

config/kibana.yml

package.json

tsconfig.base.json

tsconfig.json

boktorbb

LGTM

.eslintignore

FAQ.md

STYLEGUIDE.md

ananzh · 2021-03-12T04:43:24Z

package.json

 {
-  "name": "kibana",
-  "description": "Kibana is a browser based analytics and search dashboard for Elasticsearch. Kibana is a snap to setup and start using. Kibana strives to be easy to get started with, while also being flexible and powerful, just like Elasticsearch.",
+  "name": "opensearch-dashboards",


In line 2, why "name":"kibana" --> opensearch-dashboards not opensearchDashboards?
For version name you change to "opensearchDashboards" and in another case kibana.index: ".kibana" -->
opensearchDashboards.index: ".opensearch-dashboards". Seems all names are changes to opensearchDashboards. In line 6 you use opeansearch-dashboards bc it is an app but here it is a name so should be opensearchDashboards?

Project name is following hypen -.

tsconfig.base.json

tsconfig.json

package.json

opensearch_dashboards.d.ts

STYLEGUIDE.md

Jenkinsfile

kavilla · 2021-03-12T23:45:13Z

README.md

-Visit [Elastic.co](http://www.elastic.co/guide/en/kibana/current/index.html) for the full Kibana documentation.
+Visit [Elastic.co](http://www.elastic.co/guide/en/kibana/current/index.html) for the full OpenSearch Dashboards documentation.

 For information about building the documentation, see the README in [elastic/docs](https://github.com/elastic/docs).


package.json

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

kavilla

LGTM thanks

* [Rename] Refactored root directory files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed PR comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* feat: add core workspace module (#145) The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Miki <amoo_miki@yahoo.com>

* feat: add core workspace module (#145) The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 9e3e3a7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

* [Workspace] Feature/workspace service core module (#5092) * feat: add core workspace module (#145) The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 9e3e3a7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com>

The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

[Rename] Refactored root directory files

d8048c3

mihirsoni added >Fork rename labels Mar 10, 2021

mihirsoni requested review from boktorbb and kavilla March 10, 2021 08:27

boktorbb suggested changes Mar 10, 2021

View reviewed changes

mihirsoni added 2 commits March 11, 2021 00:23

[Rename] addressed review feedbacks

f19e5cf

[Rename] addressed review feedbacks

067ea6a

boktorbb approved these changes Mar 12, 2021

View reviewed changes

ananzh reviewed Mar 12, 2021

View reviewed changes

.eslintignore Show resolved Hide resolved

ananzh reviewed Mar 12, 2021

View reviewed changes

FAQ.md Show resolved Hide resolved

ananzh reviewed Mar 12, 2021

View reviewed changes

STYLEGUIDE.md Show resolved Hide resolved

ananzh reviewed Mar 12, 2021

View reviewed changes

tsconfig.base.json Show resolved Hide resolved

kavilla requested changes Mar 12, 2021

View reviewed changes

[Rename] addressed PR comments

bb0093f

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

kavilla approved these changes Mar 13, 2021

View reviewed changes

ananzh approved these changes Mar 13, 2021

View reviewed changes

boktorbb merged commit 397790e into opensearch-project:dashboards Mar 13, 2021

Conversation

mihirsoni commented Mar 10, 2021

Uh oh!

Uh oh!

Uh oh!

boktorbb Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boktorbb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ananzh Mar 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mihirsoni Mar 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kavilla Mar 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kavilla left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ananzh Mar 12, 2021 •

edited

Loading