[Rename] Refactored test/* director#137
Merged
boktorbb merged 5 commits intoopensearch-project:dashboardsfrom Mar 12, 2021
mihirsoni:tests
Merged
[Rename] Refactored test/* director#137boktorbb merged 5 commits intoopensearch-project:dashboardsfrom mihirsoni:tests
boktorbb merged 5 commits intoopensearch-project:dashboardsfrom
mihirsoni:tests
Conversation
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
test/functional/fixtures/es_archiver/dashboard/current/opensearch_dashboards/mappings.json
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
| ./test/scripts/jenkins_build_plugins.sh | ||
| fi | ||
|
|
||
| # doesn't persist, also set in OpenSearchDashboardsPipeline.groovy |
Member
There was a problem hiding this comment.
kibanaPipeline.groovy --->opensearchDashboardsPipeline.groovy
shouldn't use capital OpenSearch
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
requested changes
Mar 11, 2021
Member
ananzh
left a comment
ananzh
left a comment
There was a problem hiding this comment.
Hey Mihir, I wrote several comments and asked all the unsure stuff. Should be okay
boktorbb
suggested changes
Mar 12, 2021
test/accessibility/config.ts
Outdated
| require.resolve('./apps/home'), | ||
| require.resolve('./apps/filter_panel'), | ||
| require.resolve('./apps/kibana_overview'), | ||
| require.resolve('./apps/opensearch_dashboardsoverview'), |
ananzh
approved these changes
Mar 12, 2021
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] Refactored test/* directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Renamed directories and files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored test/* directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Renamed directories and files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored test/* directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Renamed directories and files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
…t#137) * hide import for application home page * add workpspace into gotoApp link * remove special logic for management workspace * variable name change and more UTs --------- (cherry picked from commit afa373a) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #37
Description of changes: [Rename] Refactored test/* directory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.