Skip to content

Comments

[Rename] telemetry#109

Merged
boktorbb merged 1 commit intoopensearch-project:dashboardsfrom
kavilla:rename-telemetry
Mar 13, 2021
Merged

[Rename] telemetry#109
boktorbb merged 1 commit intoopensearch-project:dashboardsfrom
kavilla:rename-telemetry

Conversation

@kavilla
Copy link
Member

@kavilla kavilla commented Mar 8, 2021

Issue #, if available:
#37

Description of changes:
Rename files and variables within plugins/telemetry

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kavilla kavilla requested review from boktorbb and mihirsoni March 8, 2021 23:22
@kavilla kavilla changed the base branch from main to dashboards March 8, 2021 23:22
@kavilla kavilla changed the title Rename telemetry [Rename] telemetry Mar 8, 2021
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also remove snap files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is an abbreviation, we should probably make this osd_uuid

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osd_uuid

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be either, just have no strong preference knowing we may not eve use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah are we ripping it out? Might be easier. Since now that I notice it is says ece and ess which I assume mean elastic cloud enterprise and elasticsearch service

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a meeting we discussed we will leave ece and ess for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@boktorbb boktorbb merged commit 38ca463 into opensearch-project:dashboards Mar 13, 2021
@kavilla kavilla deleted the rename-telemetry branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Aug 29, 2023
…opensearch-project#109)

* update snapshot for collapsible_nav.test.tsx and header.test.tsx

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix test error

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…opensearch-project#109)

* update snapshot for collapsible_nav.test.tsx and header.test.tsx

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix test error

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…opensearch-project#109)

* update snapshot for collapsible_nav.test.tsx and header.test.tsx

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix test error

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants