[Keyboard-shortcuts] Registered shortcuts for OSD#10509
Merged
Conversation
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
kavilla
reviewed
Sep 10, 2025
kavilla
reviewed
Sep 10, 2025
kavilla
reviewed
Sep 10, 2025
kavilla
reviewed
Sep 10, 2025
kavilla
reviewed
Sep 10, 2025
kavilla
reviewed
Sep 10, 2025
angle943
reviewed
Sep 10, 2025
angle943
requested changes
Sep 10, 2025
Collaborator
angle943
left a comment
There was a problem hiding this comment.
for all categories and name, since they are user facing, lets use i18n to translate the strings
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
angle943
previously approved these changes
Sep 11, 2025
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
angle943
previously approved these changes
Sep 11, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10509 +/- ##
==========================================
+ Coverage 62.06% 62.10% +0.03%
==========================================
Files 4293 4293
Lines 109997 110098 +101
Branches 18131 18155 +24
==========================================
+ Hits 68275 68371 +96
+ Misses 37069 37060 -9
- Partials 4653 4667 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angle943
previously approved these changes
Sep 11, 2025
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
angle943
approved these changes
Sep 15, 2025
Maosaic
approved these changes
Sep 16, 2025
ashwin-pc
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Sep 17, 2025
…#10509) * add help system Signed-off-by: Po Hong Lau <pohongl@amazon.com> * Changeset file for PR opensearch-project#10466 created/updated * update the yml Signed-off-by: Po Hong Lau <pohongl@amazon.com> * update getallshortcut Signed-off-by: Po Hong Lau <pohongl@amazon.com> * registered more shortcuts Signed-off-by: Po Hong Lau <pohongl@amazon.com> * add more shortcuts Signed-off-by: Po Hong Lau <pohongl@amazon.com> * edit button shortcut Signed-off-by: Po Hong Lau <pohongl@amazon.com> * edit button shortcut Signed-off-by: Po Hong Lau <pohongl@amazon.com> * additonal shortcuts Signed-off-by: Po Hong Lau <pohongl@amazon.com> * added more shortcuts Signed-off-by: Po Hong Lau <pohongl@amazon.com> * change console shortcut Signed-off-by: Po Hong Lau <pohongl@amazon.com> * Changeset file for PR opensearch-project#10509 created/updated * set enable shortcut only workspace also enable Signed-off-by: Po Hong Lau <pohongl@amazon.com> * using function instead of dom Signed-off-by: Po Hong Lau <pohongl@amazon.com> * change to use i18n Signed-off-by: Po Hong Lau <pohongl@amazon.com> * update the test case Signed-off-by: Po Hong Lau <pohongl@amazon.com> * Update keyboard shortcuts documentation in README.md * fix test cases Signed-off-by: Po Hong Lau <pohongl@amazon.com> * add esc for dev tools Signed-off-by: Po Hong Lau <pohongl@amazon.com> --------- Signed-off-by: Po Hong Lau <pohongl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Member
|
Linked issue: #10398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR about registered more shortcuts for OSD.
Explore
Dashboard

Dashboard (After edit mode on)

Visualizations
Changelog
Check List
yarn test:jestyarn test:jest_integration