Skip to content

[Keyboard-shortcuts] Registered shortcuts for OSD#10509

Merged
angle943 merged 25 commits into
opensearch-project:mainfrom
natel926:register_shortcuts
Sep 16, 2025
Merged

[Keyboard-shortcuts] Registered shortcuts for OSD#10509
angle943 merged 25 commits into
opensearch-project:mainfrom
natel926:register_shortcuts

Conversation

@natel926
Copy link
Copy Markdown
Contributor

@natel926 natel926 commented Sep 9, 2025

Description

The PR about registered more shortcuts for OSD.

Explore

Screenshot 2025-09-10 at 6 35 11 PM Screenshot 2025-09-10 at 6 34 26 PM

Dashboard
Screenshot 2025-09-10 at 6 35 39 PM

Dashboard (After edit mode on)
Screenshot 2025-09-10 at 6 35 39 PM

Visualizations

Screenshot 2025-09-10 at 6 36 08 PM

Changelog

  • feat: Add more keyboard shortcuts for OSD

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

natel926 and others added 13 commits August 28, 2025 17:58
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Comment thread src/plugins/data/public/ui/query_editor/query_editor_top_row.tsx Outdated
Comment thread src/plugins/data/public/ui/query_editor/query_editor_top_row.tsx Outdated
Comment thread src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx Outdated
Comment thread src/plugins/dev_tools/public/plugin.ts Outdated
Comment thread src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx
Comment thread src/plugins/visualize/public/application/components/visualize_editor_common.tsx Outdated
Copy link
Copy Markdown
Collaborator

@angle943 angle943 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all categories and name, since they are user facing, lets use i18n to translate the strings

Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
angle943
angle943 previously approved these changes Sep 11, 2025
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
angle943
angle943 previously approved these changes Sep 11, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 69.29134% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.10%. Comparing base (214a829) to head (93838a9).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...components/dashboard_top_nav/dashboard_top_nav.tsx 70.83% 6 Missing and 1 partial ⚠️
...public/application/components/dashboard_editor.tsx 0.00% 5 Missing ⚠️
src/plugins/dashboard/public/plugin.tsx 0.00% 5 Missing ⚠️
src/plugins/discover/public/plugin.ts 0.00% 5 Missing ⚠️
...ta/public/ui/query_editor/query_editor_top_row.tsx 42.85% 2 Missing and 2 partials ⚠️
...public/ui/query_string_input/query_bar_top_row.tsx 66.66% 2 Missing and 2 partials ⚠️
src/plugins/dev_tools/public/plugin.ts 0.00% 3 Missing ⚠️
...ublic/ui/query_string_input/query_string_input.tsx 75.00% 0 Missing and 2 partials ⚠️
src/plugins/dev_tools/public/dev_tools_icon.tsx 80.00% 0 Missing and 2 partials ⚠️
src/core/public/core_system.ts 80.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10509      +/-   ##
==========================================
+ Coverage   62.06%   62.10%   +0.03%     
==========================================
  Files        4293     4293              
  Lines      109997   110098     +101     
  Branches    18131    18155      +24     
==========================================
+ Hits        68275    68371      +96     
+ Misses      37069    37060       -9     
- Partials     4653     4667      +14     
Flag Coverage Δ
Linux_1 27.61% <1.96%> (-0.02%) ⬇️
Linux_2 41.48% <91.66%> (+<0.01%) ⬆️
Linux_3 39.50% <47.25%> (+0.04%) ⬆️
Linux_4 33.73% <41.37%> (+0.01%) ⬆️
Windows_1 27.62% <1.96%> (-0.02%) ⬇️
Windows_2 41.45% <91.66%> (+<0.01%) ⬆️
Windows_3 39.51% <47.25%> (+0.04%) ⬆️
Windows_4 33.73% <41.37%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

angle943
angle943 previously approved these changes Sep 11, 2025
Signed-off-by: Po Hong Lau <pohongl@amazon.com>
@angle943 angle943 merged commit b30fe22 into opensearch-project:main Sep 16, 2025
100 of 106 checks passed
ashwin-pc pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Sep 17, 2025
…#10509)

* add help system

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* Changeset file for PR opensearch-project#10466 created/updated

* update the yml

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* update getallshortcut

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* registered more shortcuts

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* add more shortcuts

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* edit button shortcut

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* edit button shortcut

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* additonal shortcuts

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* added more shortcuts

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* change console shortcut

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* Changeset file for PR opensearch-project#10509 created/updated

* set enable shortcut only workspace also enable

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* using function instead of dom

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* change to use i18n

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* update the test case

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* Update keyboard shortcuts documentation in README.md

* fix test cases

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

* add esc for dev tools

Signed-off-by: Po Hong Lau <pohongl@amazon.com>

---------

Signed-off-by: Po Hong Lau <pohongl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ps48
Copy link
Copy Markdown
Member

ps48 commented Oct 2, 2025

Linked issue: #10398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants