Update dependencies #1930
Merged
Update dependencies #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot still isn't doing this for us (see #964).
Dependabot _does_ do this for us, but we may as well do this while we're hear and save fiddling around with a bunch of individual PRs.
This was added in #1885 and can be removed now that the upstream patch has been released.
This doesn't benefit us at all (it's designed to avoid the compilation overhead when executing the same SQL over and over) and it leads to warnings when we execute clause elements whose caching behaviour has not be explicitly defined. We're getting a warning here now because we've just updated to Trino v0.328.0 which includes this PR: * trinodb/trino-python-client#429 This defines a compiler for the `Lag` clause which (because it is not restricted to a specific dialect) ends up being used by SQLite and triggering the warning.
Deploying with
|
| Latest commit: |
58b8561
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf4bcda2.databuilder.pages.dev |
| Branch Preview URL: | https://evansd-update-deps.databuilder.pages.dev |
rebkwok
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the production dependencies (which Dependabot fails to do for us, see #964) and, for good measure, updates the dev dependencies as well.
We also remove a SQLAlchemy workaround which is no longer required and participate in some faff in order to avoid a SQLAlchemy warning triggered by upgrading Trino.