Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update all dependencies with pip-compile #1156

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

StevenMaude
Copy link
Contributor

Because Dependabot isn't quite working properly: see #964.

Because Dependabot isn't quite working properly: see #964.
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 139e98c
Status: ✅  Deploy successful!
Preview URL: https://38059721.databuilder.pages.dev
Branch Preview URL: https://steve-update-dependencies-20.databuilder.pages.dev

View logs

We aren't calling a logger's `new()`, `bind()` or `unbind()` methods,
so assuming this is unused.

It was originally copied over from cohort-extractor, for which the code
was initially added a while ago.

The current way of doing things if this is needed is to use
`contextvars`:

```python
structlog.contextvars.bind_contextvars()
structlog.contextvars.unbind_contextvars()
```

https://www.structlog.org/en/22.3.0/thread-local.html
https://www.structlog.org/en/22.3.0/contextvars.html
@StevenMaude
Copy link
Contributor Author

StevenMaude commented Mar 16, 2023

The only issue here is with a deprecation warning from structlog.

From reading around the structlog documentation and hynek/structlog#487, and searching around the Data Builder source, I think the configuration change is safe to remove as mentioned in the commit message, but please correct me if not.

Copy link
Member

@iaindillingham iaindillingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this, as I believe you're away until the 27th @StevenMaude.

@iaindillingham iaindillingham merged commit fd8b8c3 into main Mar 17, 2023
@iaindillingham iaindillingham deleted the steve/update-dependencies-2023-03 branch March 17, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants