Always signal when comparing with signalling NaN #167
+4
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up on discussion in openrisc#164. Previously, comparisons with signalling NaN would set `FPCSR[IVF]` only for ordered/unordered EQ/NE. Now, all comparisons set this flag when operating on a signalling NaN. Updated formal verification of `pfpu_cmp` to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on discussion in #164. Previously, comparisons with signalling NaN would set
FPCSR[IVF]only for ordered/unordered EQ/NE. Now, all comparisons set this flag when operating on a signalling NaN.Updated formal verification of
pfpu_cmpto match.