Skip to content

Do not derive relative links from index html when deriving metadata in MavenPomDownloader#6217

Merged
timtebeek merged 1 commit intomainfrom
fix-maven-pom-downloader
Oct 29, 2025
Merged

Do not derive relative links from index html when deriving metadata in MavenPomDownloader#6217
timtebeek merged 1 commit intomainfrom
fix-maven-pom-downloader

Conversation

@Jenson3210
Copy link
Copy Markdown
Contributor

Cli is failing to install with:
Screenshot 2025-10-29 at 15 13 24

This is due to the html body of the browsing page to have a url href that matches the lookup, but has nothing to do with versions:
Screenshot 2025-10-29 at 15 15 49
Screenshot 2025-10-29 at 15 16 28

By checking if this is a relative url, we eliminate this possibility and the added test now passes

@Jenson3210 Jenson3210 requested a review from timtebeek October 29, 2025 14:17
@Jenson3210 Jenson3210 self-assigned this Oct 29, 2025
@Jenson3210 Jenson3210 added the bug Something isn't working label Oct 29, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Oct 29, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Oct 29, 2025
@timtebeek timtebeek merged commit 623ee5e into main Oct 29, 2025
2 checks passed
@timtebeek timtebeek deleted the fix-maven-pom-downloader branch October 29, 2025 15:14
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants