Conversation
shanman190
reviewed
Oct 28, 2025
| with: | ||
| java_version: | | ||
| 25 | ||
| 21 |
Contributor
There was a problem hiding this comment.
I think we'll need to keep 21 available for the Java toolchains to utilize for rewrite-groovy and rewrite-kotlin as otherwise, those versions are incompatible with JDK 25 at present.
timtebeek
changed the title
timtebeek
reviewed
Oct 29, 2025
| testImplementation(project(":rewrite-groovy")) | ||
| testRuntimeOnly("org.antlr:antlr4-runtime:4.13.2") | ||
| testRuntimeOnly(project(":rewrite-java-21")) | ||
| testRuntimeOnly(project(":rewrite-java-25")) |
Member
There was a problem hiding this comment.
Some downstream projects rely on this transitive dependency for their Java parser. I wonder what using 25 here will do for their tests when those concern using gradle, but I'll guess we'll see over the next hours and otherwise change this back.
timtebeek
approved these changes
Oct 29, 2025
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Consolidating on Java 25 so that we have a consistent development experience across recipe modules.