Skip to content

Adapt @EnabledOnJre, @DisabledOnJre, @EnabledForJreRange and @DisabledForJreRange for JUnit 6's Java 17 minimum #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 24 commits into from
Aug 26, 2025
Merged

Adapt @EnabledOnJre, @DisabledOnJre, @EnabledForJreRange and @DisabledForJreRange for JUnit 6's Java 17 minimum #795

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d7ecfca
Initial version of MinimumJreConditions recipe
Jenson3210 Aug 20, 2025
ec50315
support statically imported versions
Jenson3210 Aug 20, 2025
b399680
run best practices
Jenson3210 Aug 20, 2025
b20039a
run best practices
Jenson3210 Aug 20, 2025
104ae7d
Use `@ValueSource` instead of `@CsvSource` where there's a single arg
timtebeek Aug 20, 2025
e359ec9
Review comments:
Jenson3210 Aug 21, 2025
e71aaf1
order annotations
Jenson3210 Aug 21, 2025
824609d
update range tests
Jenson3210 Aug 21, 2025
571a8e5
Also update Ranges to single value annotations or update their start JRE
Jenson3210 Aug 22, 2025
a07a107
Also update Ranges to single value annotations or update their start JRE
Jenson3210 Aug 22, 2025
34c92b8
Run best practices
Jenson3210 Aug 22, 2025
90b5bc2
Remove JRE imports from compilation unit as well
timtebeek Aug 22, 2025
122f8dc
Move documentation example to the top of the unit tests
timtebeek Aug 22, 2025
b789ede
Revert "Remove JRE imports from compilation unit as well"
timtebeek Aug 22, 2025
c517606
Minor touch up in text blocks to avoid confusion
timtebeek Aug 22, 2025
a4ad02d
comments
Jenson3210 Aug 22, 2025
826fed0
Adapted to remove tests (=always disabled) or remove annotation (alwa…
Jenson3210 Aug 22, 2025
ecd695b
comments
Jenson3210 Aug 22, 2025
65504ce
comments
Jenson3210 Aug 22, 2025
51cfcdf
comments
Jenson3210 Aug 22, 2025
0d44256
Do not get versions eagerly, but only when default is not found
timtebeek Aug 22, 2025
36d39f4
Minor polish
timtebeek Aug 22, 2025
cf3f682
Use `Literal::getStrings` for `versions` Strings
timtebeek Aug 22, 2025
f84e82f
Added one more deprecation
Jenson3210 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading