Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for negative variants of startsWith, endsWith, and matches #594

Conversation

Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Sep 7, 2024

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek added the recipe Recipe request label Sep 7, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot for the quick work on this!

@Tahanima
Copy link
Contributor Author

Tahanima commented Sep 7, 2024

Perfect, thanks a lot for the quick work on this!

My pleasure! I really appreciate your prompt reply.

@timtebeek timtebeek merged commit 5c23f07 into openrewrite:main Sep 7, 2024
2 checks passed
@timtebeek
Copy link
Contributor

My pleasure! I really appreciate your prompt reply.

Of course! It's what we strive for here. Welcome to the project! :)

@timtebeek
Copy link
Contributor

Your change should become available through our snapshot versions in ~15 minutes or so; we release every two weeks, with the next one scheduled for Wednesday. Hope that helps!

And if you spot any more improvements we'd love to hear. There's no need to create an issue first, although it's appreciated when you call out existing issues as you did here. 😊

@Tahanima
Copy link
Contributor Author

Tahanima commented Sep 7, 2024

Of course! It's what we strive for here. Welcome to the project! :)

Thank you so much! 😃

Your change should become available through our snapshot versions in ~15 minutes or so; we release every two weeks, with the next one scheduled for Wednesday. Hope that helps!

And if you spot any more improvements we'd love to hear. There's no need to create an issue first, although it's appreciated when you call out existing issues as you did here. 😊

Got it! Thanks for letting me know. 😃

@Tahanima Tahanima deleted the feature/simplify-negated-chained-assertions-with-assertj branch September 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants