Replace empty String concatenation with String.valueOf()
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timtebeek
commented
Jul 9, 2025
timtebeek
commented
- Fixes Recipe to avoid concatenating with empty String to perform type conversion #628
This recipe replaces inefficient string concatenation patterns like
`"" + ...` with `String.valueOf(...)`. This improves code readability
and may have minor performance benefits.
The recipe preserves parentheses when they exist in the original
expression, e.g., ("" + 42) becomes (String.valueOf(42)).
Fixes #628
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
…ring types - Use TypeUtils.isString() instead of comparing with JavaType.Primitive.String - Update test expectation for comment preservation (known JavaTemplate limitation) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Member
Author
|
Seeing some perhaps undesirable effects: |
Contributor
This might look a bit off as it violates the symmetry of the code text, but I think it's fine actually. |
Contributor
|
This PR is stale because it has been open for 90 days with no activity. Remove |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/staticanalysis/ReplaceStringConcatenationWithStringValueOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/ReplaceStringConcatenationWithStringValueOf.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.