Skip to content

Handle JaxbAnnotationIntrospector and JacksonJsonProvider in migration #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 3 commits into from
Nov 13, 2025
Merged

Handle JaxbAnnotationIntrospector and JacksonJsonProvider in migration #936

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a41e4fe
Handle JaxbAnnotationIntrospector and JacksonJsonProvider in migration
Nov 12, 2025
a539ed5
Use ChangePackage to convert other classes as well
timtebeek Nov 13, 2025
a1f73fb
Merge branch 'main' into yizeng/jackson-migration
timtebeek Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/resources/META-INF/rewrite/jakarta-ee-9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,6 +1055,12 @@ recipeList:
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: com.fasterxml.jackson.module.jaxb.JaxbAnnotationModule
newFullyQualifiedTypeName: com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationModule
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector
newFullyQualifiedTypeName: com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider
newFullyQualifiedTypeName: com.fasterxml.jackson.jakarta.rs.json.JacksonJsonProvider

@timtebeek timtebeek Nov 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this proposed fix; Seeing the lines just above also changing classes from those same packages I wonder if it would make sense to swap out these ChangeType instances for ChangePackage. Any thoughts there? Are there classes in the old packages that we should not convert similarly?

@CalvinZengyi CalvinZengyi Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rapid response!

Good question. I did a little bit more digging, and it appears that it may not be feasible to generalize these into ChangePackage. Existing line 1052-1054 is an example (see screenshot as well): the class name has also changed.

btw, let me know if you think it would be helpful to add a few more lines to cover all the classes in the screenshot .

image

@timtebeek timtebeek Nov 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful screenshot! We could then still use ChangePackage to handle the cases where the class name hasn't changed, which I've applied just now. With that we're good to merge, thanks!

@CalvinZengyi CalvinZengyi Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
(and wow, I learned a new trick on writing recipes from you today!)


---
type: specs.openrewrite.org/v1beta/recipe
Expand Down
42 changes: 42 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/jakarta/JacksonJavaxtoJakartaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,4 +354,46 @@ public class A extends JacksonXmlBindJsonProvider {}
)
);
}

@Test
void rewriteJaxbAnnotationIntrospectorToJakartaXmlBindAnnotationIntrospector() {
rewriteRun(
spec -> spec.parser(JavaParser.fromJavaVersion().classpath("jackson-module-jaxb-annotations")),
//language=java
java(
"""
import com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector;

public class A extends JaxbAnnotationIntrospector {}
""",
"""
import com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;

public class A extends JakartaXmlBindAnnotationIntrospector {}
"""
)
);
}

@Test
void rewriteJacksonJsonProviderToJacksonJsonProvider() {
rewriteRun(
spec -> spec.parser(JavaParser.fromJavaVersion().classpath(
"jackson-databind",
"jackson-jaxrs-json-provider")),
//language=java
java(
"""
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;

public class A extends JacksonJsonProvider {}
""",
"""
import com.fasterxml.jackson.jakarta.rs.json.JacksonJsonProvider;

public class A extends JacksonJsonProvider {}
"""
)
);
}
}