Skip to content

Use type tables for tests #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 4 commits into from
Sep 24, 2025
Merged

Use type tables for tests #856

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc82cce
Fix failing `RemovalsServletJakarta10Test` tests
knutwannheden Sep 24, 2025
ad94d6f
Remove `logCompilationWarningsAndErrors()` call
knutwannheden Sep 24, 2025
afed373
Fix another failing test
knutwannheden Sep 24, 2025
9a5b2ec
Move test classpath jars to type table
knutwannheden Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ recipeDependencies {
parserClasspath("javax.annotation:javax.annotation-api:1.3.2")
parserClasspath("com.google.guava:guava:33.5.0-jre")
parserClasspath("com.google.errorprone:error_prone_core:2.+")
testParserClasspath("jakarta.servlet:jakarta.servlet-api:5.0.+")
Comment thread
knutwannheden marked this conversation as resolved.
Outdated
}

val rewriteVersion = rewriteRecipe.rewriteVersion.get()
Expand Down Expand Up @@ -76,7 +77,6 @@ dependencies {
testRuntimeOnly("com.google.code.findbugs:jsr305:3.0.2")
testRuntimeOnly("javax.mail:mail:1.4.7")
testRuntimeOnly("javax.mail:javax.mail-api:1.6.2")
testRuntimeOnly("javax.servlet:javax.servlet-api:4.0.1")
testRuntimeOnly("javax.ws.rs:javax.ws.rs-api:2.1.1")
testRuntimeOnly(gradleApi())
}
Expand Down
4 changes: 1 addition & 3 deletions src/test/java/org/openrewrite/java/migrate/jakarta/RemovalsServletJakarta10Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ class RemovalsServletJakarta10Test implements RewriteTest {
public void defaults(RecipeSpec spec) {
spec.parser(JavaParser.fromJavaVersion()
.classpathFromResources(new InMemoryExecutionContext(),
"javax.servlet-api-4.0.0",
"jakarta.servlet-api-5.0.0",
"jakarta.servlet-api-6.0.0"))
"jakarta.servlet-api-5.0"))
.recipeFromResource("/META-INF/rewrite/jakarta-ee-10.yml", "org.openrewrite.java.migrate.jakarta.RemovalsServletJakarta10");
}

Expand Down
Binary file added src/test/resources/META-INF/rewrite/classpath.tsv.gz
View file
Open in desktop
Binary file not shown.
Loading