Skip to content

Migrate to commons-fileupload2-jakarta #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 13 commits into from
Aug 15, 2025
Merged

Migrate to commons-fileupload2-jakarta #819

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1f33afd
#815 Migrate JakartaEE9 add fileupload update
ChenyuWang98 Aug 13, 2025
9c689cf
Merge branch 'main' into ChenyuWang98-patch-1
timtebeek Aug 13, 2025
40e32ca
use fileupload 2.0.0-M4
ChenyuWang98 Aug 14, 2025
4d9c408
Merge branch 'main' into ChenyuWang98-patch-1
ChenyuWang98 Aug 14, 2025
aae3f68
servlet5 use 2.0.0-M1
ChenyuWang98 Aug 14, 2025
2918700
jakartaEE10 update upload2-jakarta-servlet6
ChenyuWang98 Aug 14, 2025
1f70b81
Revert unintended change
timtebeek Aug 14, 2025
fb9e028
Merge branch 'main' into ChenyuWang98-patch-1
timtebeek Aug 14, 2025
57e4d84
Revert unintended change
timtebeek Aug 14, 2025
9be762f
Fix typo
timtebeek Aug 14, 2025
279dce7
Only bump the dependency version for EE10
timtebeek Aug 14, 2025
f0b93c7
Only change the package for EE10
timtebeek Aug 14, 2025
9e42755
Change the outdated milestone dependencies as well
timtebeek Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/main/resources/META-INF/rewrite/jakarta-ee-9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ recipeList:
- org.openrewrite.java.migrate.jakarta.JavaxDecoratorToJakartaDecorator
- org.openrewrite.java.migrate.jakarta.JavaxEjbToJakartaEjb
- org.openrewrite.java.migrate.jakarta.JavaxElToJakartaEl
- org.openrewrite.java.migrate.jakarta.FileuploadToFileUpload2
- org.openrewrite.java.migrate.jakarta.JavaxEnterpriseToJakartaEnterprise
- org.openrewrite.java.migrate.jakarta.Faces2xMigrationToJakartaFaces3x
- org.openrewrite.java.migrate.jakarta.JavaxInjectMigrationToJakartaInject
Expand Down Expand Up @@ -313,6 +314,42 @@ recipeList:
recursive: true
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.jakarta.FileuploadToFileUpload2
displayName: Migrate deprecated `org.apache.commons.fileload` packages to `org.apache.commons.fileload.core`
description: Migrate deprecated `org.apache.commons.fileload` packages to `org.apache.commons.fileload.core`
recipeList:
- org.openrewrite.java.dependencies.ChangeDependency:
oldGroupId: commons-fileupload
oldArtifactId: commons-fileupload
newGroupId: org.apache.commons
newArtifactId: commons-fileupload2-jakarta
newVersion: 2.0.0-M1
Comment thread
timtebeek marked this conversation as resolved.
Outdated
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.apache.commons
artifactId: commons-fileupload2-jakarta
newVersion: 2.0.0-M1
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: org.apache.commons
artifactId: commons-fileupload2-core
newVersion: 2.0.0-M1
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: org.apache.commons.fileload.servlet.ServletFileUpload
newFullyQualifiedTypeName: org.apache.commons.fileload.jakarta.JakartaServletFileUpload

@timtebeek timtebeek Aug 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest milestone there appear to be two options, each with a different package:
https://github.com/apache/commons-fileupload/blob/master/commons-fileupload2-jakarta-servlet5/src/main/java/org/apache/commons/fileupload2/jakarta/servlet5/JakartaServletFileUpload.java
https://github.com/apache/commons-fileupload/blob/master/commons-fileupload2-jakarta-servlet6/src/main/java/org/apache/commons/fileupload2/jakarta/servlet6/JakartaServletFileUpload.java

What made you pick this version and package?

- org.openrewrite.java.ChangePackage:
oldPackageName: org.apache.commons.fileload.disk
newPackageName: org.apache.commons.fileload.core
recursive: true
- org.openrewrite.java.ChangePackage:
oldPackageName: org.apache.commons.fileload.servlet
newPackageName: org.apache.commons.fileload.jakarta
recursive: true
- org.openrewrite.java.ChangePackage:
oldPackageName: org.apache.commons.fileload
newPackageName: org.apache.commons.fileload.core
recursive: true

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.jakarta.JavaxEnterpriseToJakartaEnterprise
displayName: Migrate deprecated `javax.enterprise` packages to `jakarta.enterprise`
description: Java EE has been rebranded to Jakarta EE, necessitating a package relocation.
Expand Down