Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JacksonJavaxToJakarta] Rewrite JaxbAnnotationModule to JakartaXmlBindAnnotationModule #654

Merged
merged 4 commits into from
Jan 5, 2025
Merged

[JacksonJavaxToJakarta] Rewrite JaxbAnnotationModule to JakartaXmlBindAnnotationModule #654

merged 4 commits into from
Jan 5, 2025

Conversation

FieteO
Copy link
Contributor

@FieteO FieteO commented Jan 5, 2025 •
edited by timtebeek
Loading

What's changed?

This PR declares an additional ChangeType step in the jakarta-ee-9.yml to rewrite the JaxbAnnotationsModule to the JakartaXmlBindAnnotationModule.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@FieteO FieteO changed the title 652 jackson jaxb to jakarta annotation module [JacksonJavaxToJakarta] Rewrite JaxbAnnotationModule to JakartaXmlBindAnnotationModule Jan 5, 2025
@timtebeek timtebeek self-requested a review January 5, 2025 12:16
github-actions[bot]
github-actions bot reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/UpdateSdkMan.java
    • lines 36-36

timtebeek
timtebeek approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @FieteO ! Really helpful. :)

@timtebeek timtebeek merged commit b3bb13c into openrewrite:main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@timtebeek timtebeek timtebeek approved these changes

Assignees

@FieteO FieteO

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JacksonJavaxToJakarta] JaxbAnnotationModule not rewritten to JakartaXmlBindAnnotationModule
2 participants
@FieteO @timtebeek