Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joda time to Java time: Add few more templates for migration #619

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Joda time to Java time: Add few more templates for migration #619

merged 1 commit into from
Dec 4, 2024

Conversation

amishra-u
Copy link
Contributor

@amishra-u amishra-u commented Dec 4, 2024 •
edited by timtebeek
Loading

What's changed?

Added migration templates for joda-time methods for the following classes:
BaseDuration
BaseInterval

Also fixed the classpath for threeten library from the previous pr

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review December 4, 2024 22:17
timtebeek
timtebeek approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks again!

@timtebeek timtebeek merged commit 39507e5 into openrewrite:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@amishra-u amishra-u

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amishra-u @timtebeek