Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jspecify nullmarked #600

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

bwijsmuller
Copy link
Contributor

What's changed?

ParametersAreNonnullByDefault on package-info.java files migration

What's your motivation?

We need a replacement for the default not-null annotations.

Anything in particular you'd like reviewers to focus on?

NA

Anyone you would like to review specifically?

NA

Have you considered any alternatives or workarounds?

NA

Any additional context

NA

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bwijsmuller bwijsmuller marked this pull request as ready for review November 12, 2024 09:34
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for the immediate fix!

@timtebeek timtebeek added the enhancement New feature or request label Nov 12, 2024
@timtebeek timtebeek merged commit 941c654 into openrewrite:main Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants