Skip to content

Conversation

@mike-solomon
Copy link
Contributor

To explain the JS LST types and how they work with J types.

To explain the JS LST types and how they work with J types.
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Oct 29, 2025
Copy link
Contributor

@greg-at-moderne greg-at-moderne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

One thing I noticed that not all JS LST elements are mentioned. Not sure if this doc aims at being an exhaustive reference. If so, they should be added. If it's meant just to indicate the concepts of two "namespaces" like J and JS - then I suggest to add some disclaimer sentence at the top like "Some of the most important JS types are:" or similar.
And if the latter - then some of the JS elements mentioned don't seem so crucial to me - e.g. all these called *Type*.

@mike-solomon
Copy link
Contributor Author

Thanks for the feedback @greg-at-moderne -- my intention wasn't to provide all LST types but, rather, to just pick the most important ones. I did my best guess at it - but I don't really work with any of this stuff so there's definitely bound to be mistakes 😅

Is every LST type that's really important included in here? Is the main issue that we have 3 Type* LSTs defined that aren't really important?

Either way - I'll make sure to update the doc with a clearer intro that only some of the types are included.

@greg-at-moderne
Copy link
Contributor

Is every LST type that's really important included in here? Is the main issue that we have 3 Type* LSTs defined that aren't really important?

I think it's good to have this "what's new in JS, when you know Java LSTs" document. And if so, there's probably no need to list all JS LST elements.

Copy link
Contributor

@greg-at-moderne greg-at-moderne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
TBH I haven't checked the LST trees in the examples sections in details, but they look good at the first glance.

All in all, I think it's well done.

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Nov 3, 2025
@mike-solomon mike-solomon merged commit 39af0d5 into master Nov 3, 2025
5 checks passed
@mike-solomon mike-solomon deleted the js-lst branch November 3, 2025 18:31
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants