tests: added a test case for interrupted file I/O during readall. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentzh
reviewed
Dec 21, 2017
| end | ||
|
|
||
| local cmd = string.format("kill -%d %d && sleep 0.1", signal, pid) | ||
| assert(io.popen(cmd):read("*a")) |
There was a problem hiding this comment.
It would be great if we could add a test case for the case when the underlying read() syscall encounters an error other than EINTR. But it seems tricky without the help of special instrumenting facility like gdb or systemtap :(
There was a problem hiding this comment.
I think I found a way! See the latest patch.
thibaultcha
force-pushed
the
tests/eintr
branch
from
fc3c086 to
758d132
Compare
thibaultcha
force-pushed
the
tests/eintr
branch
from
758d132 to
e0c8f90
Compare
|
@thibaultcha Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure which suite to put the test in for now (signals.t seems to be slightly different). Please provide feedback if it needs to be moved.
It is a bit late right now, so I only tested it on Darwin and Linux, and the test consistently fails when nginx is compiled with openresty/luajit2 -b v2.1-agentzh.
.travis.ymlchange): https://travis-ci.org/thibaultcha/resty-cli/builds/319602486Let me know how this looks :)