Style compliance for Jupyter Notebooks #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 23 23
Lines 4541 4541
=======================================
Hits 4177 4177
Misses 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mgrover1
approved these changes
Aug 23, 2024
mgrover1
requested changes
Aug 23, 2024
kmuehlbauer
approved these changes
Aug 23, 2024
|
Thanks for the fix here @rcjackson - merging once the tests pass 👍 |
Done! |
mgrover1
approved these changes
Aug 23, 2024
rcjackson
added a commit
to rcjackson/xradar
that referenced
this pull request
Aug 23, 2024
* ADD: MRR2 backend * Revert "ADD: MRR2 backend" This reverts commit e377116. * Fixed format to pass ruff. * ADD: Documenting the changes in history.md * FIX: Cmweather imports * Cmweather oh cmweather * ADD: MVC * ADD: Link to PR in history.md
kmuehlbauer
added a commit
that referenced
this pull request
Oct 16, 2024
* ADD: MRR2 backend * Revert "ADD: MRR2 backend" This reverts commit e377116. * FIX: Style compliance for Jupyter Notebooks (#199) * ADD: MRR2 backend * Revert "ADD: MRR2 backend" This reverts commit e377116. * Fixed format to pass ruff. * ADD: Documenting the changes in history.md * FIX: Cmweather imports * Cmweather oh cmweather * ADD: MVC * ADD: Link to PR in history.md * ADD: History.md * New MRR2 branch * ADD: Black * Try ds = None * FIX: Delete .gz file after download * Ruff! * ADD: Set data variables to None upon closing. * Black * FIX: Trying context managers for Datasets. * Set raw data variables to None * Close file earlier? * ADD: ds.ds.close for DataTrees, otherwise we have > 4.2 million references remaining * ADD: No more _data * TST: Remove -n auto * STY: Black * unlock parallel processing in CI again * reorganize metek tests * tmp_path_factory in tests * keep metek tests in test_metek.py * link missing notebooks to toc --------- Co-authored-by: Kai Mühlbauer <[email protected]>
rcjackson
added a commit
to rcjackson/xradar
that referenced
this pull request
Nov 26, 2024
* ADD: MRR2 backend * Revert "ADD: MRR2 backend" This reverts commit e377116. * FIX: Style compliance for Jupyter Notebooks (openradar#199) * ADD: MRR2 backend * Revert "ADD: MRR2 backend" This reverts commit e377116. * Fixed format to pass ruff. * ADD: Documenting the changes in history.md * FIX: Cmweather imports * Cmweather oh cmweather * ADD: MVC * ADD: Link to PR in history.md * ADD: History.md * New MRR2 branch * ADD: Black * Try ds = None * FIX: Delete .gz file after download * Ruff! * ADD: Set data variables to None upon closing. * Black * FIX: Trying context managers for Datasets. * Set raw data variables to None * Close file earlier? * ADD: ds.ds.close for DataTrees, otherwise we have > 4.2 million references remaining * ADD: No more _data * TST: Remove -n auto * STY: Black * unlock parallel processing in CI again * reorganize metek tests * tmp_path_factory in tests * keep metek tests in test_metek.py * link missing notebooks to toc --------- Co-authored-by: Kai Mühlbauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history.mdThe notebooks were not compliant with Ruff's style checker. This PR fixes that.