docs: Add Amazon Cognito as tested provider

README.md

@@ -510,15 +510,16 @@ opkssh add root alice@example.com https://authentik.local/application/o/opkssh/
 
 ### Tested
 
-| OpenID Provider                           | Tested | Notes                                                                                                       |
-|-------------------------------------------|--------|-------------------------------------------------------------------------------------------------------------|
-| [Authelia](https://www.authelia.com/)     | ✅      | [Authelia Integration Guide](https://www.authelia.com/integration/openid-connect/opkssh/)                   |
-| [Authentik](https://goauthentik.io/)      | ✅      | Do not add a certificate in the encryption section of the provider                                          |
-| [Azure](https://www.azure.com/)           | ✅      | [Entra ID (Azure) Integration Guide](docs/providers/azure.md)
-| [Gitlab Self-hosted](https://gitlab.com/) | ✅      | [Configuration guide](docs/gitlab-selfhosted.md)                                                            |
-| [Kanidm](https://kanidm.com/)             | ✅      | [Kanidm Integration Guide](https://kanidm.github.io/kanidm/master/integrations/oauth2/examples.html#opkssh) |
-| [PocketID](https://pocket-id.org/)        | ✅      | Create a new OIDC Client and inside the new client, check "Public client" on OIDC Client Settings           |
-| [Zitadel](https://zitadel.com/)           | ✅      | Check the UserInfo box on the Token Settings                                                                |
+| OpenID Provider                                | Tested | Notes                                                                                                   |
+|------------------------------------------------|--------|---------------------------------------------   ---------------------------------------------------------|
+| [Authelia](https://www.authelia.com/)          | ✅     | [Authelia Integration Guide](https://www.authelia.com/integration/openid-connect/opkssh/)               |
+| [Authentik](https://goauthentik.io/)           | ✅     | Do not add a certificate in the encryption section of the provider                                      |
+| [AWS Cognito](https://aws.amazon.com/cognito/) | ✅     | [Amazon Cognito Integration Guide](docs/providers/cognito.md)                                           |
+| [Azure](https://www.azure.com/)                | ✅     | [Entra ID (Azure) Integration Guide](docs/providers/azure.md)                                           |
+| [Gitlab Self-hosted](https://gitlab.com/)      | ✅     | [Configuration guide](docs/gitlab-selfhosted.md)                                                        |
+| [Kanidm](https://kanidm.com/)                  | ✅  | [Kanidm Integration Guide](https://kanidm.github.io/kanidm/master/integrations/oauth2/examples.html#opkssh)|
+| [PocketID](https://pocket-id.org/)             | ✅     | Create a new OIDC Client and inside the new client, check "Public client" on OIDC Client Settings       |
+| [Zitadel](https://zitadel.com/)                | ✅     | Check the UserInfo box on the Token Settings                                                            |
 
 Do not use Confidential/Secret mode **only** client ID is needed.
 

docs/providers/azure.md

@@ -73,27 +73,27 @@ It should look like it does here with Redirect URIs showing "3 public client".
 For each server you have installed opkssh on, edit the file `/etc/opk/providers` and set the Azure provider to use the client ID and tenant ID you just registered.
 
 ```
-https://login.microsoftonline.com/{TENANT ID}/v2.0 {CLIENT ID} 12h
+https://login.microsoftonline.com/{TENANT ID}/v2.0 <CLIENT-ID> 12h
 ```
 
-To test run `opkssh login --provider="https://login.microsoftonline.com/{TENANT ID}/v2.0,{CLIENT ID}"` with the client ID you registered.
+To test run `opkssh login --provider="https://login.microsoftonline.com/{TENANT ID}/v2.0,<CLIENT-ID>"` with the client ID you registered.
 If this works then server has been setup correctly.
 
 On the client check to see if you have already created a config at `~/.opk/config.yml`. If no config if found, create a config by running `opkssh login --create-config`.
 
 Then edit `~/.opk/config.yml` and change the entry for azure to use the client ID and tenant ID from the App Registration.
 
 ```yaml
-  - alias: azure microsoft
-    issuer: https://login.microsoftonline.com/{TENANT ID}/v2.0
-    client_id: {CLIENT ID}
-    scopes: openid profile email offline_access
-    access_type: offline
-    prompt: consent
-    redirect_uris:
-      - http://localhost:3000/login-callback
-      - http://localhost:10001/login-callback
-      - http://localhost:11110/login-callback
+- alias: azure microsoft
+  issuer: https://login.microsoftonline.com/{TENANT ID}/v2.0
+  client_id: <CLIENT-ID>
+  scopes: openid profile email offline_access
+  access_type: offline
+  prompt: consent
+  redirect_uris:
+    - http://localhost:3000/login-callback
+    - http://localhost:10001/login-callback
+    - http://localhost:11110/login-callback
 ```
 
 For more information see: [opkssh configuration files](https://github.com/openpubkey/opkssh/blob/main/docs/config.md).
@@ -141,16 +141,16 @@ On the client check to see if you have already created a config at `~/.opk/confi
 Edit `~/.opk/config.yml` and for the azure provider change `prompt: consent` to `prompt: none` as shown below.
 
 ```yaml
-  - alias: azure microsoft
-    issuer: https://login.microsoftonline.com/{TENANT ID}/v2.0
-    client_id: {CLIENT ID}
-    scopes: openid profile email offline_access
-    access_type: offline
-    prompt: none
-    redirect_uris:
-      - http://localhost:3000/login-callback
-      - http://localhost:10001/login-callback
-      - http://localhost:11110/login-callback
+- alias: azure microsoft
+  issuer: https://login.microsoftonline.com/{TENANT ID}/v2.0
+  client_id: <CLIENT-ID>
+  scopes: openid profile email offline_access
+  access_type: offline
+  prompt: none
+  redirect_uris:
+    - http://localhost:3000/login-callback
+    - http://localhost:10001/login-callback
+    - http://localhost:11110/login-callback
 ```
 
 See Issue: [Workaround for error message when using EntraID](https://github.com/openpubkey/opkssh/issues/253).

docs/providers/cognito.md

@@ -0,0 +1,173 @@
+# Configuring Amazon Cognito for OPKSSH
+
+Setting up Amazon Cognito with OPKSSH is simple and should not take more than 10 minutes.
+To make this process as straightforward as possible we provide this guide.
+
+**Something not working?** Open a new issue on <https://github.com/openpubkey/opkssh>
+
+This guide is divided into two sections depending on if you have an existing Cognito User Pool or not.
+
+- [**Setup without existing User Pool**](#setup-without-existing-user-pool)
+- [**Setup with existing User Pool**](#setup-with-existing-user-pool)
+
+Afterwards both sections converge at [**Modifying the App**](#modifying-the-app) where you will modify the app to add redirect URIs required by OPKSSH.
+
+## Setup without existing User Pool
+
+### 1. Create the User Pool
+
+If you do not have an existing Cognito User Pool you can create one quickly by following these steps:
+
+Start by going to [Amazon Cognito](https://us-east-1.console.aws.amazon.com/cognito/v2/idp/user-pools) and click `"Create user pool"`.
+
+The name you specify will be the name of the Application, **not** the User Pool. Use a name like `"OPKSSH"`.
+
+> [!WARNING]
+>
+> Make sure you select `"Single Page Application (SPA)"`, otherwise AWS will create a Client Secret.
+
+> [!TIP]
+>
+> Check you are in the correct AWS region.
+
+![User Pool Create](cognito_figs/user_pool_create.png)
+
+Decide options for sign-in identifiers and required attributes for signup, as they can never be changed later. We will setup return_uri's later.
+
+Once ready click `"Create user directory"`.
+
+### 2. Navigate to the App
+
+Once the User Pool is created you will be taken to a Success page. Go to the bottom and click `"Go to overview"`. At this point you should see something like this:
+
+![User Pool Created](cognito_figs/user_pool_created.png)
+
+> [!TIP]
+>
+> At this point you should rename your User Pool to something more meaningful like `"Datacenter Team"`.
+
+Jump to the section [**Modifying the App**](#modifying-the-app) to continue the setup.
+
+## Setup with existing User Pool
+
+If you already have an existing User Pool, navigate to `"App clients"` section and click `"Create app client"`.
+
+Enter a name of the application, like `"OPKSSH"`. **Remember to select `"Single Page Application (SPA)"`**.
+
+![App Client Create](cognito_figs/app_client_create.png)
+
+We will setup return_uri's later. Once ready click `"Create app client"`.
+
+> [!WARNING]
+>
+> Make sure you select `"Single Page Application (SPA)"`, otherwise AWS will create a Client Secret.
+
+## Modifying the App
+
+Inside your User Pool, click on `"App clients"` in the left-hand menu.
+
+You should see the App you created earlier. Click on the App name.
+
+![App Client Info Old](cognito_figs/app_client_info_old.png)
+
+### 1. Edit Login Info
+
+In the navigation bar in the middle of the screen, click `"Login pages"` and then `"Edit"`.
+
+Under `"Allowed callback URLs"` section, click the `"Add another URL"` button twice, and then make sure all 3 of the following URLs are present:
+
+```
+http://localhost:3000/login-callback
+http://localhost:10001/login-callback
+http://localhost:11110/login-callback
+```
+
+![App Client Redirect URIs](cognito_figs/app_client_redirect_uris.png)
+
+You also **MUST** edit the `"OpenID Connect Scopes"` section by removing **Phone** and adding **Profile**:
+
+**OLD:**
+
+![OpenID Scopes Old](cognito_figs/openid_scopes_old.png)
+
+**NEW:**
+
+![OpenID Scopes New](cognito_figs/openid_scopes_new.png)
+
+Click `"Save Changes"`.
+
+### 2. Add a Managed Login page
+
+If you go to the App > `"Login pages"` > `"Managed login style"` section, you can see if the App has a managed login page or not.
+
+![Managed Login Empty](cognito_figs/managed_login_empty.png)
+
+If you only see a `"-"` under `"Managed login style"`, you need to create one. Go to `"Managed login"` on the left-hand sidebar, under `"Styles"` click `"Create a new style"`. Select your app and click `"Create"`.
+
+![Managed Login Create](cognito_figs/managed_login_create.png)
+
+Your app should now be ready.
+
+### Configure OPKSSH
+
+For each server you have installed opkssh on, edit the file `/etc/opk/providers` and set the Cognito provider to the client ID and tenant ID you just registered.
+
+> [!WARNING]
+>
+> **ATTENTION!** Do **NOT** specify your managed login domain if you have a custom domain. You must specify the IDP endpoint which is of the form:
+
+```
+https://cognito-idp.<aws-region>.amazonaws.com/<user-pool-id> <CLIENT-ID> 12h
+```
+
+To test run `opkssh login --provider="https://cognito-idp.us-east-1.amazonaws.com/us-east-1_xxxxxxxxx,<CLIENT-ID>"` with the User Pool ID and Client ID you registered. If this works then the App has been setup correctly.
+
+On the client check to see if you have already created a config at `~/.opk/config.yml`. If no config if found, create a config by running `opkssh login --create-config`.
+
+Then edit `~/.opk/config.yml` and add an entry for Cognito to use the User Pool and Client ID from the App Registration.
+
+```yaml
+- alias: cognito
+  issuer: https://cognito-idp.<aws-region>.amazonaws.com/<user-pool-id>
+  client_id: <CLIENT-ID>
+  scopes: openid profile email
+  access_type: offline
+  prompt: consent
+  redirect_uris:
+    - http://localhost:3000/login-callback
+    - http://localhost:10001/login-callback
+    - http://localhost:11110/login-callback
+```
+
+For more information see: [opkssh configuration files](https://github.com/openpubkey/opkssh/blob/main/docs/config.md).
+
+### 3. Test
+
+Then run `opkssh login` or `opkssh login cognito` on the client.
+This should run without error.
+
+## Troubleshooting (Common Issues)
+
+### Error message: failed to exchange token: oauth2: "invalid_client" "invalid_client_secret"
+
+This occurs if you (accidentally) created the App so that it has a Client Secret. There is no way to fix this. Go to `"App clients"` and delete the App. Then recreate it making sure to select `"Single Page Application (SPA)"`. Follow the [Setup with existing User Pool](#setup-with-existing-user-pool) section again.
+
+### Error message: 403 Forbidden: You don't have permission to access this resource
+
+This can occur if you have a WAF which is enforcing the `"AWSManagedRulesCommonRuleSet"` rule group. Add an exception for `"EC2MetaDataSSRF_QUERYARGUMENTS"` to your WAF rules.
+
+Terraform/OpenTofu example:
+
+```hcl
+# Exclude EC2MetaDataSSRF_QUERYARGUMENTS for Cognito OAuth2 flows
+rule_action_override {
+    name = "EC2MetaDataSSRF_QUERYARGUMENTS"
+    action_to_use {
+        count {}
+    }
+}
+```
+
+### OPKSSH not seeing Cognito groups
+
+This is completely untested. Please test and amend this section.