-
Notifications
You must be signed in to change notification settings - Fork 82
Add test kwarg to methods #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test kwarg to methods #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions about changes in explicit parameter passing in function headers.
openproblems/tasks/multimodal_data_integration/methods/harmonic_alignment.py
Show resolved
Hide resolved
@danielStrobl if this gets merged, you will need to adapt this convention into the batch removal PR as well. Just a heads up for now. |
…cottgigante-immunai/openproblems into scottgigante/feature/method_test_kwarg
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 86.36% 85.18% -1.19%
==========================================
Files 77 77
Lines 1702 1735 +33
Branches 100 107 +7
==========================================
+ Hits 1470 1478 +8
- Misses 201 220 +19
- Partials 31 37 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
def beta(adata, n_top_genes=500, threshold=1): | ||
adata = _atac_genes_score(adata, top_genes=n_top_genes, threshold=threshold) | ||
def beta(adata, test=False, top_genes=500, threshold=1): | ||
adata = _atac_genes_score(adata, top_genes=top_genes, threshold=threshold) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know anything about this method, but would top_genes
not also be a test parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know about the n_svd = n_svd or 20
notation. Pretty cool! Only 1 question about the beta function parameter top_genes
.
Prerequisite for #313
Submission type
Testing
Submission guidelines
PR review checklist
This PR will be evaluated on the basis of the following checks: