Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Assorted XML issues #945

Merged
merged 1 commit into from
Aug 21, 2024
Merged

FIX: Assorted XML issues #945

merged 1 commit into from
Aug 21, 2024

Conversation

carlwilson
Copy link
Member

  • added a dedicated method to XmlModuleHandler to handle entity resolution;
  • entity resolution now handles multiple redirects;
  • added new catcvhes for 307 and 308 redirect status codes.
  • removed line numbers from XML info messages to prevent pathalogical info message repeats; and
  • added test data to prevent regressions of the above.

Closes #918

- added a dedicated method to `XmlModuleHandler` to handle entity resolution;
- entity resolution now handles multiple redirects;
- added new catcvhes for `307` and `308` redirect status codes.
- removed line numbers from XML info messages to prevent pathalogical info message repeats; and
- added test data to prevent regressions of the above.

Closes #918
@carlwilson carlwilson added the bug A product defect that needs fixing label Aug 21, 2024
@carlwilson carlwilson added this to the JHOVE 1.32 milestone Aug 21, 2024
@carlwilson carlwilson self-assigned this Aug 21, 2024
@carlwilson carlwilson merged commit b807508 into integration Aug 21, 2024
6 checks passed
@carlwilson carlwilson deleted the fix/xml-redirect branch September 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML incorrectly not-well-formed because of http in Link to Schema
1 participant